Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2453683007: Revert of Crazylinker: remove the code to load component build library (Closed)

Created:
4 years, 1 month ago by michaelbai
Modified:
4 years, 1 month ago
Reviewers:
Torne
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Crazylinker: remove the code to load component build library (patchset #4 id:60001 of https://codereview.chromium.org/2406083002/ ) Reason for revert: Wrong change about comment Original issue's description: > Crazylinker: remove the code to load component build library > > The code is broken, component build library will not be loaded if > non-component build library is in system lib path, e.g. Chrome is > preinstalled. > > BUG=657093 > > Committed: https://crrev.com/275c325caaec3cc65f0c3be9af0abd00963e9d01 > Cr-Commit-Position: refs/heads/master@{#427809} TBR=torne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657093 Committed: https://crrev.com/6e23b4d09d51ef90bfb50cf9763acc1ee2cd381f Cr-Commit-Position: refs/heads/master@{#428059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M base/android/java/src/org/chromium/base/library_loader/Linker.java View 1 chunk +11 lines, -3 lines 0 comments Download
M base/android/linker/config.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
michaelbai
Created Revert of Crazylinker: remove the code to load component build library
4 years, 1 month ago (2016-10-27 16:54:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453683007/1
4 years, 1 month ago (2016-10-27 16:55:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 16:56:02 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 17:00:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e23b4d09d51ef90bfb50cf9763acc1ee2cd381f
Cr-Commit-Position: refs/heads/master@{#428059}

Powered by Google App Engine
This is Rietveld 408576698