Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2453683004: Disable the CPU tracing agent on Windows (Closed)

Created:
4 years, 1 month ago by charliea (OOO until 10-5)
Modified:
4 years, 1 month ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, rnephew (Reviews Here)
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Disable the CPU tracing agent on Windows This will allow us to reenable it on other platforms. BUG=chromium:647443 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/42836761f6ea7edc8dc9bb3ded09c305f3baee45

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Disable tests on Windows also #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py View 1 1 chunk +4 lines, -1 line 0 comments Download
M telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent_unittest.py View 1 2 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
charliea (OOO until 10-5)
4 years, 1 month ago (2016-10-26 21:15:36 UTC) #2
rnephew (Reviews Here)
https://codereview.chromium.org/2453683004/diff/1/telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py File telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py (right): https://codereview.chromium.org/2453683004/diff/1/telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py#newcode162 telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py:162: return (os_name in ['mac', 'linux']) Should there be a ...
4 years, 1 month ago (2016-10-26 21:16:53 UTC) #4
charliea (OOO until 10-5)
https://codereview.chromium.org/2453683004/diff/1/telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py File telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py (right): https://codereview.chromium.org/2453683004/diff/1/telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py#newcode162 telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py:162: return (os_name in ['mac', 'linux']) On 2016/10/26 21:16:53, rnephew ...
4 years, 1 month ago (2016-10-26 21:27:53 UTC) #5
nednguyen
lgtm
4 years, 1 month ago (2016-10-26 21:34:44 UTC) #6
nednguyen
On 2016/10/26 21:34:44, nednguyen wrote: > lgtm Note that its output on Linux & Mac ...
4 years, 1 month ago (2016-10-26 21:35:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453683004/20001
4 years, 1 month ago (2016-11-01 15:15:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/5359)
4 years, 1 month ago (2016-11-01 15:40:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453683004/40001
4 years, 1 month ago (2016-11-01 17:35:42 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 17:56:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698