Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py

Issue 2453683004: Disable the CPU tracing agent on Windows (Closed)
Patch Set: Disable tests on Windows also Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py
diff --git a/telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py b/telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py
index 44cc1b10c9e58047ed54086e0f28553ac4ba15b6..d176aba67509f27464525897584bda97703c6799 100644
--- a/telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py
+++ b/telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent.py
@@ -159,7 +159,10 @@ class CpuTracingAgent(tracing_agent.TracingAgent):
@classmethod
def IsSupported(cls, platform_backend):
os_name = platform_backend.GetOSName()
- return (os_name in ['mac', 'linux']) or (os_name == 'win' and psutil)
+ # TODO(charliea): Reenable this once the CPU tracing agent is fixed on
+ # Windows.
+ # http://crbug.com/647443
+ return (os_name in ['mac', 'linux'])
def StartAgentTracing(self, config, timeout):
assert not self._snapshot_ongoing, (
« no previous file with comments | « no previous file | telemetry/telemetry/internal/platform/tracing_agent/cpu_tracing_agent_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698