Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2453633005: [ic] Properly deal with all oddballs when updating BinaryOpIC state. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Properly deal with all oddballs when updating BinaryOpIC state. R=jarin@chromium.org BUG=chromium:659967 Committed: https://crrev.com/305948fa76c19679cbc1822a5d95b358d7561dd5 Cr-Commit-Position: refs/heads/master@{#40616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/ic/ic-state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-659967.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 1 month ago (2016-10-27 11:38:54 UTC) #1
Jarin
lgtm
4 years, 1 month ago (2016-10-27 11:43:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453633005/1
4 years, 1 month ago (2016-10-27 12:14:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 12:16:10 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:15:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/305948fa76c19679cbc1822a5d95b358d7561dd5
Cr-Commit-Position: refs/heads/master@{#40616}

Powered by Google App Engine
This is Rietveld 408576698