Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: src/ic/ic-state.cc

Issue 2453633005: [ic] Properly deal with all oddballs when updating BinaryOpIC state. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-659967.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic-state.cc
diff --git a/src/ic/ic-state.cc b/src/ic/ic-state.cc
index efbcf03ce5ee6e6448563ff1c8d1e15656b29a96..f94803681bb8d6f8350f8f421386331cd051a887 100644
--- a/src/ic/ic-state.cc
+++ b/src/ic/ic-state.cc
@@ -256,10 +256,10 @@ void BinaryOpICState::Update(Handle<Object> left, Handle<Object> right,
if (old_extra_ic_state == GetExtraICState()) {
// Tagged operations can lead to non-truncating HChanges
- if (left->IsUndefined(isolate_) || left->IsBoolean()) {
+ if (left->IsOddball()) {
left_kind_ = GENERIC;
} else {
- DCHECK(right->IsUndefined(isolate_) || right->IsBoolean());
+ DCHECK(right->IsOddball());
right_kind_ = GENERIC;
}
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-659967.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698