third_party/WebKit/Source/core/layout/ng/ng_length_utils.h - Issue 2453553002: Resolve ApplyAutoMargins's TODO in NGBlockLayoutAlgorithm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

Issue 2453553002: Resolve ApplyAutoMargins's TODO in NGBlockLayoutAlgorithm. (Closed)

Patch Set: change ApplyAutoMargins to pass margins by pointer + DCHECK Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

index c9eafc071031624b1f28a2d3382e181399b01f52..17bcfb96cbb016b120dcf28a82e991c7ee669e2a 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

@@ -71,7 +71,7 @@ CORE_EXPORT NGBoxStrut ComputePadding(const NGConstraintSpace&,

CORE_EXPORT void ApplyAutoMargins(const NGConstraintSpace&,

const ComputedStyle&,

const NGFragment&,

- NGBoxStrut& margins);

+ NGBoxStrut* margins);

} // namespace blink