Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils.h

Issue 2453553002: Resolve ApplyAutoMargins's TODO in NGBlockLayoutAlgorithm. (Closed)
Patch Set: change ApplyAutoMargins to pass margins by pointer + DCHECK Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NGLengthUtils_h 5 #ifndef NGLengthUtils_h
6 #define NGLengthUtils_h 6 #define NGLengthUtils_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/layout/ng/ng_direction.h" 9 #include "core/layout/ng/ng_direction.h"
10 #include "core/layout/ng/ng_writing_mode.h" 10 #include "core/layout/ng/ng_writing_mode.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 CORE_EXPORT NGBoxStrut ComputePadding(const NGConstraintSpace&, 64 CORE_EXPORT NGBoxStrut ComputePadding(const NGConstraintSpace&,
65 const ComputedStyle&); 65 const ComputedStyle&);
66 66
67 // Resolves margin: auto in the inline direction after a box has been laid out. 67 // Resolves margin: auto in the inline direction after a box has been laid out.
68 // This uses the container size from the constraint space and the box size from 68 // This uses the container size from the constraint space and the box size from
69 // the fragment to compute the margins that are auto, if any, and adjusts 69 // the fragment to compute the margins that are auto, if any, and adjusts
70 // the given NGBoxStrut accordingly. 70 // the given NGBoxStrut accordingly.
71 CORE_EXPORT void ApplyAutoMargins(const NGConstraintSpace&, 71 CORE_EXPORT void ApplyAutoMargins(const NGConstraintSpace&,
72 const ComputedStyle&, 72 const ComputedStyle&,
73 const NGFragment&, 73 const NGFragment&,
74 NGBoxStrut& margins); 74 NGBoxStrut* margins);
75 75
76 } // namespace blink 76 } // namespace blink
77 77
78 #endif // NGLengthUtils_h 78 #endif // NGLengthUtils_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698