Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2453503002: Revert "Simplify handling of text input types in RenderWidget." (Closed)

Created:
4 years, 1 month ago by dglazkov
Modified:
4 years, 1 month ago
Reviewers:
esprehn
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert "Simplify handling of text input types in RenderWidget." This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df, because it broke IME. BUG=653958 TBR=esprehn Review-Url: https://codereview.chromium.org/2442323004 Cr-Commit-Position: refs/heads/master@{#427396} (cherry picked from commit 97b6c2bd1278f651b9b30e22685ede87f761a9ca) Committed: https://chromium.googlesource.com/chromium/src/+/cddb25425a67f01e75126631a0e03a6b86b1fa3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -42 lines) Patch
M content/renderer/render_widget.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 6 chunks +18 lines, -42 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
dglazkov
Committed patchset #1 (id:1) manually as cddb25425a67f01e75126631a0e03a6b86b1fa3a.
4 years, 1 month ago (2016-10-25 18:02:09 UTC) #2
dglazkov
4 years, 1 month ago (2016-10-25 19:47:48 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2447213002/ by dglazkov@chromium.org.

The reason for reverting is: Bad diff editing on my part..

Powered by Google App Engine
This is Rietveld 408576698