|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by dglazkov Modified:
4 years, 1 month ago Reviewers:
esprehn CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, mlamouri+watch-content_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert "Simplify handling of text input types in RenderWidget."
This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df,
because it broke IME.
BUG=653958
TBR=esprehn
Committed: https://crrev.com/97b6c2bd1278f651b9b30e22685ede87f761a9ca
Cr-Commit-Position: refs/heads/master@{#427396}
Patch Set 1 #Patch Set 2 : Reformat. #Patch Set 3 : Fix compile. #Patch Set 4 : Rebased. #
Messages
Total messages: 32 (20 generated)
The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Reformat.
The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm
All ur bots are red :[
On 2016/10/24 at 22:38:14, esprehn wrote: > All ur bots are red :[ I think it's the lack of IME test coverage that makes them sad. :P
Fix compile.
The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dglazkov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org Link to the patchset: https://codereview.chromium.org/2442323004/#ps40001 (title: "Fix compile.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Rebased.
The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dglazkov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org Link to the patchset: https://codereview.chromium.org/2442323004/#ps60001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Revert "Simplify handling of text input types in RenderWidget." This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df, because it broke IME. BUG=653958 TBR=esprehn ========== to ========== Revert "Simplify handling of text input types in RenderWidget." This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df, because it broke IME. BUG=653958 TBR=esprehn Committed: https://crrev.com/97b6c2bd1278f651b9b30e22685ede87f761a9ca Cr-Commit-Position: refs/heads/master@{#427396} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/97b6c2bd1278f651b9b30e22685ede87f761a9ca Cr-Commit-Position: refs/heads/master@{#427396} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
