Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2442323004: Revert "Simplify handling of text input types in RenderWidget." (Closed)

Created:
4 years, 1 month ago by dglazkov
Modified:
4 years, 1 month ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Simplify handling of text input types in RenderWidget." This reverts commit 03c1f6703465e6a0289c8799455afb62f87071df, because it broke IME. BUG=653958 TBR=esprehn Committed: https://crrev.com/97b6c2bd1278f651b9b30e22685ede87f761a9ca Cr-Commit-Position: refs/heads/master@{#427396}

Patch Set 1 #

Patch Set 2 : Reformat. #

Patch Set 3 : Fix compile. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M content/renderer/render_widget.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 6 chunks +20 lines, -7 lines 0 comments Download
A + third_party/WebKit/public/web/WebTextInputType.h View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 32 (20 generated)
dglazkov
4 years, 1 month ago (2016-10-24 21:46:54 UTC) #1
dglazkov
Reformat.
4 years, 1 month ago (2016-10-24 21:48:35 UTC) #4
esprehn
lgtm
4 years, 1 month ago (2016-10-24 22:38:03 UTC) #9
esprehn
All ur bots are red :[
4 years, 1 month ago (2016-10-24 22:38:14 UTC) #10
dglazkov
On 2016/10/24 at 22:38:14, esprehn wrote: > All ur bots are red :[ I think ...
4 years, 1 month ago (2016-10-24 22:42:16 UTC) #11
dglazkov
Fix compile.
4 years, 1 month ago (2016-10-24 22:53:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442323004/40001
4 years, 1 month ago (2016-10-25 15:31:53 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/288802)
4 years, 1 month ago (2016-10-25 15:38:26 UTC) #21
dglazkov
Rebased.
4 years, 1 month ago (2016-10-25 16:01:58 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442323004/60001
4 years, 1 month ago (2016-10-25 17:28:45 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-25 17:36:22 UTC) #30
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 17:43:48 UTC) #32
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/97b6c2bd1278f651b9b30e22685ede87f761a9ca
Cr-Commit-Position: refs/heads/master@{#427396}

Powered by Google App Engine
This is Rietveld 408576698