Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Unified Diff: ios/web/web_state/ui/crw_web_controller_container_view.mm

Issue 2453473002: Zero-out crw_web_controller's container view delegate in dealloc. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/ui/crw_web_controller_container_view.mm
diff --git a/ios/web/web_state/ui/crw_web_controller_container_view.mm b/ios/web/web_state/ui/crw_web_controller_container_view.mm
index 754d9e8b814f4d013b8d1d24e9f24cf48d3314e0..d6a885fcadec8949a2c00facd55b3e33f4bcaea3 100644
--- a/ios/web/web_state/ui/crw_web_controller_container_view.mm
+++ b/ios/web/web_state/ui/crw_web_controller_container_view.mm
@@ -152,6 +152,14 @@
#pragma mark Accessors
+- (id<CRWWebControllerContainerViewDelegate>)delegate {
Eugene But (OOO till 7-30) 2016/10/25 18:11:12 nit: could you please keep the same methods order
+ return _delegate.get();
+}
+
+- (void)setDelegate:(id<CRWWebControllerContainerViewDelegate>)delegate {
+ _delegate.reset(delegate);
+}
+
- (CRWWebViewContentView*)webViewContentView {
return _webViewContentView.get();
}

Powered by Google App Engine
This is Rietveld 408576698