Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2453473002: Zero-out crw_web_controller's container view delegate in dealloc. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 944494a6005ea7c1d5d1072e04c913dfc4307aaa..cb93adeba2a29f6c3333d1e03a1fbefd5c2cdb45 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -1114,6 +1114,7 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
DCHECK([NSThread isMainThread]);
DCHECK(_isBeingDestroyed); // 'close' must have been called already.
DCHECK(!_webView);
+ [_containerView setDelegate:nil];
Eugene But (OOO till 7-30) 2016/10/25 18:24:34 Is this change temporary? If so, could you please
_touchTrackingRecognizer.get().touchTrackingDelegate = nil;
[[_webViewProxy scrollViewProxy] removeObserver:self];
[[NSNotificationCenter defaultCenter] removeObserver:self];

Powered by Google App Engine
This is Rietveld 408576698