Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2453463006: Revert "Revert "Recognize and optimize a.runtimeType == b.runtimeType pattern."" (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "Recognize and optimize a.runtimeType == b.runtimeType pattern."" This reverts commit 890f694de5fecdda128851ded06ea40ecd3c6c07. Previous commit was passing field_type_map_ down in a place where it was not passed down before. This caused some handles to be used across zones, which caused crashes. BUG= Committed: https://github.com/dart-lang/sdk/commit/e495e100dd8ec132b5e2f971ba79ef3e4f0896e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1109 lines, -65 lines) Patch
M runtime/lib/double.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/lib/integers.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/lib/object.cc View 1 chunk +44 lines, -2 lines 0 comments Download
M runtime/lib/object_patch.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/string_patch.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/aot_optimizer.h View 3 chunks +8 lines, -1 line 0 comments Download
M runtime/vm/aot_optimizer.cc View 6 chunks +107 lines, -6 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/compiler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_inliner.h View 3 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 3 chunks +36 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language.h View 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 2 chunks +145 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 2 chunks +145 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 2 chunks +157 lines, -4 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 2 chunks +150 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 2 chunks +155 lines, -4 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/jit_optimizer.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object_store.h View 3 chunks +10 lines, -2 lines 0 comments Download
M runtime/vm/precompiler.h View 3 chunks +13 lines, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 15 chunks +35 lines, -19 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Vyacheslav Egorov (Google)
I have fixed the issue with precompiler that caused revert. The issue was in Precompiler::ProcessFunction ...
4 years, 1 month ago (2016-10-26 08:36:36 UTC) #2
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-10-26 10:25:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e495e100dd8ec132b5e2f971ba79ef3e4f0896e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698