Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: runtime/lib/object_patch.dart

Issue 2453463006: Revert "Revert "Recognize and optimize a.runtimeType == b.runtimeType pattern."" (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/lib/string_patch.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 @patch class Object { 5 @patch class Object {
6 6
7 // The VM has its own implementation of equals. 7 // The VM has its own implementation of equals.
8 bool operator ==(other) native "Object_equals"; 8 bool operator ==(other) native "Object_equals";
9 9
10 // Helpers used to implement hashCode. If a hashCode is used, we remember it 10 // Helpers used to implement hashCode. If a hashCode is used, we remember it
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 @patch noSuchMethod(Invocation invocation) { 46 @patch noSuchMethod(Invocation invocation) {
47 return _noSuchMethod(invocation.isMethod, 47 return _noSuchMethod(invocation.isMethod,
48 internal.Symbol.getName(invocation.memberName), 48 internal.Symbol.getName(invocation.memberName),
49 invocation._type, 49 invocation._type,
50 invocation.positionalArguments, 50 invocation.positionalArguments,
51 _symbolMapToStringMap(invocation.namedArguments)); 51 _symbolMapToStringMap(invocation.namedArguments));
52 } 52 }
53 53
54 @patch Type get runtimeType native "Object_runtimeType"; 54 @patch Type get runtimeType native "Object_runtimeType";
55 55
56 static bool _haveSameRuntimeType(a, b) native "Object_haveSameRuntimeType";
57
56 // Call this function instead of inlining instanceof, thus collecting 58 // Call this function instead of inlining instanceof, thus collecting
57 // type feedback and reducing code size of unoptimized code. 59 // type feedback and reducing code size of unoptimized code.
58 bool _instanceOf(instantiator_type_arguments, type, bool negate) 60 bool _instanceOf(instantiator_type_arguments, type, bool negate)
59 native "Object_instanceOf"; 61 native "Object_instanceOf";
60 62
61 // Group of functions for implementing fast simple instance of. 63 // Group of functions for implementing fast simple instance of.
62 bool _simpleInstanceOf(type) native "Object_simpleInstanceOf"; 64 bool _simpleInstanceOf(type) native "Object_simpleInstanceOf";
63 bool _simpleInstanceOfTrue(type) => true; 65 bool _simpleInstanceOfTrue(type) => true;
64 bool _simpleInstanceOfFalse(type) => false; 66 bool _simpleInstanceOfFalse(type) => false;
65 67
66 bool _instanceOfDouble(bool negate) native "Object_instanceOfDouble"; 68 bool _instanceOfDouble(bool negate) native "Object_instanceOfDouble";
67 bool _instanceOfNum(bool negate) native "Object_instanceOfNum"; 69 bool _instanceOfNum(bool negate) native "Object_instanceOfNum";
68 bool _instanceOfInt(bool negate) native "Object_instanceOfInt"; 70 bool _instanceOfInt(bool negate) native "Object_instanceOfInt";
69 bool _instanceOfSmi(bool negate) native "Object_instanceOfSmi"; 71 bool _instanceOfSmi(bool negate) native "Object_instanceOfSmi";
70 bool _instanceOfString(bool negate) native "Object_instanceOfString"; 72 bool _instanceOfString(bool negate) native "Object_instanceOfString";
71 73
72 // Call this function instead of inlining 'as', thus collecting type 74 // Call this function instead of inlining 'as', thus collecting type
73 // feedback. Returns receiver. 75 // feedback. Returns receiver.
74 _as(instantiator_type_arguments, type) native "Object_as"; 76 _as(instantiator_type_arguments, type) native "Object_as";
75 77
76 static _symbolMapToStringMap(Map<Symbol, dynamic> map) { 78 static _symbolMapToStringMap(Map<Symbol, dynamic> map) {
77 var result = new Map<String, dynamic>(); 79 var result = new Map<String, dynamic>();
78 map.forEach((Symbol key, value) { 80 map.forEach((Symbol key, value) {
79 result[internal.Symbol.getName(key)] = value; 81 result[internal.Symbol.getName(key)] = value;
80 }); 82 });
81 return result; 83 return result;
82 } 84 }
83 } 85 }
OLDNEW
« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/lib/string_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698