Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2453463004: Add support for shipping type in web payments (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years, 1 month ago
Reviewers:
Mathieu, Tom Sepez, gone
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, haraken, rouslan+payments_chromium.org, agrieve+watch_chromium.org, blink-reviews, darin (slow to review), sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for shipping type in web payments This API lets the page influence how the shipping address is described. - https://github.com/w3c/browser-payment-api/pull/270 - https://w3c.github.io/browser-payment-api/#idl-def-paymentshippingtype BUG=648052 Committed: https://crrev.com/6c7fdd6d44a07c9ad6e46d7ba33072fc6a22ddae Cr-Commit-Position: refs/heads/master@{#427738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -21 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 2 chunks +4 lines, -1 line 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/payments/ShippingStrings.java View 1 chunk +84 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 6 chunks +12 lines, -6 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 2 chunks +50 lines, -14 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M components/payments/payment_request.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
please use gerrit instead
dfalcantara, ptal chrome/android/. mathp, ptal third_party/WebKit/. tsepez, ptal components/payments/payment_request.mojom.
4 years, 1 month ago (2016-10-25 19:46:33 UTC) #12
Tom Sepez
lgtm
4 years, 1 month ago (2016-10-25 20:11:57 UTC) #13
Mathieu
WebKit lgtm
4 years, 1 month ago (2016-10-26 01:55:45 UTC) #16
gone
lgtm
4 years, 1 month ago (2016-10-26 17:29:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453463004/40001
4 years, 1 month ago (2016-10-26 17:37:10 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 1 month ago (2016-10-26 17:42:06 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 17:51:09 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c7fdd6d44a07c9ad6e46d7ba33072fc6a22ddae
Cr-Commit-Position: refs/heads/master@{#427738}

Powered by Google App Engine
This is Rietveld 408576698