chrome/browser/android/banners/app_banner_manager_android.cc - Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2453423002: Send all of the icon URLs listed in Web Manifest to WebAPK Server. (Closed)

Patch Set: Remove best_icon_url and best_icon_hash from metadata, but add all icon urls and icon hashs in. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/banners/app_banner_manager_android.cc

diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc

index dfd17f1003c18cd67564c62ec4be6281b6958a58..19d644dd26b536186d1ed31af1f98bed83d9986a 100644

--- a/chrome/browser/android/banners/app_banner_manager_android.cc

+++ b/chrome/browser/android/banners/app_banner_manager_android.cc

@@ -43,7 +43,7 @@ std::unique_ptr<ShortcutInfo> CreateShortcutInfo(

if (!manifest.IsEmpty()) {

shortcut_info->UpdateFromManifest(manifest);

shortcut_info->manifest_url = manifest_url;

- shortcut_info->icon_url = icon_url;

+ shortcut_info->best_icon_url = icon_url;

shortcut_info->UpdateSource(ShortcutInfo::SOURCE_APP_BANNER);

}

return shortcut_info;