Convert editing/spelling/spelling-attribute-change.html with spellcheck_test

Convert editing/spelling/spelling-attribute-change.html with spellcheck_test

This patch converts the layout test with spellcheck_test as a
preparation for implementing idle time spellchecker.

BUG=517298
Committed: https://crrev.com/6cbd6a82fe8a1d750c06eec6ca76ebf34638eec3
Cr-Commit-Position: refs/heads/master@{#428656}

[Xiaocheng, 2016-10-28 07:42:45]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 07:42:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-28 07:44:03]

Description was changed from

==========
Convert editing/spelling/spelling-attribute-change.html with spellcheck_test

BUG=
==========

to

==========
Convert editing/spelling/spelling-attribute-change.html with spellcheck_test

This patch converts the layout test with spellcheck_test as a
preparation for implementing idle time spellchecker.

BUG=517298
==========

[Xiaocheng, 2016-10-28 08:38:49]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-10-28 08:38:50]

PTAL.

[commit-bot: I haz the power, 2016-10-28 08:39:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 08:39:32]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-28 08:43:52]

https://codereview.chromium.org/2453313005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/spelling/spelling-attribute-change.html
(right):

https://codereview.chromium.org/2453313005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/spelling/spelling-attribute-change.html:33:
testElementTypes.forEach(type => {
Please don't use control-flow to generate sample in testing.

[Xiaocheng, 2016-10-28 09:21:01]

Updated. PTAL.

https://codereview.chromium.org/2453313005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/editing/spelling/spelling-attribute-change.html
(right):

https://codereview.chromium.org/2453313005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/spelling/spelling-attribute-change.html:33:
testElementTypes.forEach(type => {
On 2016/10/28 at 08:43:52, Yosi_UTC9 wrote:
> Please don't use control-flow to generate sample in testing.

Done.

[yosin_UTC9, 2016-10-28 09:54:45]

Sorry, I should explain more. We should understand test cases at glance rather
than reading code.

So, I expect

spellcheck_test('sample 1', ...);
spellcheck_test('sample 2', ...);

rather than

function getnerateInput(number) { return `sample ${number}; }
spellcheck_test(generateInput(1), ...);
spellcheck_test(generateInput(1), ...);

https://codereview.chromium.org/2453313005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/editing/spelling/spelling-attribute-change.html
(right):

https://codereview.chromium.org/2453313005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/spelling/spelling-attribute-change.html:34:
generateInputText('span', undefined),
I mean we should have literal instead of computed value.

[Xiaocheng, 2016-10-28 10:33:25]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 10:33:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 11:44:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 11:44:05]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-31 02:14:52]

PTAL?

[yosin_UTC9, 2016-10-31 03:36:58]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-10-31 03:36:58]

lgtm

[commit-bot: I haz the power, 2016-10-31 03:37:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 05:25:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-31 05:27:23]

Description was changed from

==========
Convert editing/spelling/spelling-attribute-change.html with spellcheck_test

This patch converts the layout test with spellcheck_test as a
preparation for implementing idle time spellchecker.

BUG=517298
==========

to

==========
Convert editing/spelling/spelling-attribute-change.html with spellcheck_test

This patch converts the layout test with spellcheck_test as a
preparation for implementing idle time spellchecker.

BUG=517298

Committed: https://crrev.com/6cbd6a82fe8a1d750c06eec6ca76ebf34638eec3
Cr-Commit-Position: refs/heads/master@{#428656}
==========

[commit-bot: I haz the power, 2016-10-31 05:27:24]

Patchset 3 (id:??) landed as
https://crrev.com/6cbd6a82fe8a1d750c06eec6ca76ebf34638eec3
Cr-Commit-Position: refs/heads/master@{#428656}