 Chromium Code Reviews
 Chromium Code Reviews Issue 2453313005:
  Convert editing/spelling/spelling-attribute-change.html with spellcheck_test  (Closed)
    
  
    Issue 2453313005:
  Convert editing/spelling/spelling-attribute-change.html with spellcheck_test  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> | 1 <!doctype html> | 
| 2 <html> | 2 <script src="../../resources/testharness.js"></script> | 
| 3 <head> | 3 <script src="../../resources/testharnessreport.js"></script> | 
| 4 <script src="../../resources/js-test.js"></script> | 4 <script src="../assert_selection.js"></script> | 
| 5 </head> | 5 <script src="spellcheck_test.js"></script> | 
| 6 <body> | 6 | 
| 7 <p id="description"></p> | 7 <script> | 
| 8 <div id="console"></div> | 8 const testElementTypes = ['span', 'input', 'textarea']; | 
| 9 <script src="script-tests/spelling-attribute-change.js"></script> | 9 const initialValues = [undefined, true, false]; | 
| 10 </body> | 10 const finalValues = [true, false]; | 
| 11 </html> | 11 | 
| 12 function generateInputText(type, value) { | |
| 13 var text = `<${type} ${type === 'span' ? 'contenteditable ' : ''}id="target"`; | |
| 14 if (value !== undefined) | |
| 15 text += ` spellcheck="${value}"`; | |
| 16 text += '>'; | |
| 17 if (type !== 'input') | |
| 18 text += `</${type}>`; | |
| 19 return text; | |
| 20 } | |
| 21 | |
| 22 function generateExpectedText(type, value) { | |
| 23 const misspelling = value ? '#zz#' : 'zz'; | |
| 24 var text = `<${type} ${type === 'span' ? 'contenteditable ' : ''}id="target" s pellcheck="${value}"`; | |
| 25 if (type === 'input') { | |
| 26 text += ` value="Hello,${misspelling}.">`; | |
| 27 } else { | |
| 28 text += `>Hello,${misspelling}.</${type}>`; | |
| 29 } | |
| 30 return text; | |
| 31 } | |
| 32 | |
| 33 spellcheck_test( | |
| 34 generateInputText('span', undefined), | |
| 
yosin_UTC9
2016/10/28 09:54:45
I mean we should have literal instead of computed
 | |
| 35 document => { | |
| 36 const target = document.getElementById('target'); | |
| 37 target.spellcheck = true; | |
| 38 target.focus(); | |
| 39 document.execCommand('insertText', false, 'Hello,'); | |
| 40 document.execCommand('insertText', false, 'zz.'); | |
| 41 }, | |
| 42 generateExpectedText('span', true), | |
| 43 'Change "spellcheck" of <span> from undefined to true'); | |
| 44 | |
| 45 spellcheck_test( | |
| 46 generateInputText('span', undefined), | |
| 47 document => { | |
| 48 const target = document.getElementById('target'); | |
| 49 target.spellcheck = false; | |
| 50 target.focus(); | |
| 51 document.execCommand('insertText', false, 'Hello,'); | |
| 52 document.execCommand('insertText', false, 'zz.'); | |
| 53 }, | |
| 54 generateExpectedText('span', false), | |
| 55 'Change "spellcheck" of <span> from undefined to false'); | |
| 56 | |
| 57 spellcheck_test( | |
| 58 generateInputText('span', true), | |
| 59 document => { | |
| 60 const target = document.getElementById('target'); | |
| 61 target.spellcheck = true; | |
| 62 target.focus(); | |
| 63 document.execCommand('insertText', false, 'Hello,'); | |
| 64 document.execCommand('insertText', false, 'zz.'); | |
| 65 }, | |
| 66 generateExpectedText('span', true), | |
| 67 'Change "spellcheck" of <span> from true to true'); | |
| 68 | |
| 69 spellcheck_test( | |
| 70 generateInputText('span', true), | |
| 71 document => { | |
| 72 const target = document.getElementById('target'); | |
| 73 target.spellcheck = false; | |
| 74 target.focus(); | |
| 75 document.execCommand('insertText', false, 'Hello,'); | |
| 76 document.execCommand('insertText', false, 'zz.'); | |
| 77 }, | |
| 78 generateExpectedText('span', false), | |
| 79 'Change "spellcheck" of <span> from true to false'); | |
| 80 | |
| 81 spellcheck_test( | |
| 82 generateInputText('span', false), | |
| 83 document => { | |
| 84 const target = document.getElementById('target'); | |
| 85 target.spellcheck = true; | |
| 86 target.focus(); | |
| 87 document.execCommand('insertText', false, 'Hello,'); | |
| 88 document.execCommand('insertText', false, 'zz.'); | |
| 89 }, | |
| 90 generateExpectedText('span', true), | |
| 91 'Change "spellcheck" of <span> from false to true'); | |
| 92 | |
| 93 spellcheck_test( | |
| 94 generateInputText('span', false), | |
| 95 document => { | |
| 96 const target = document.getElementById('target'); | |
| 97 target.spellcheck = false; | |
| 98 target.focus(); | |
| 99 document.execCommand('insertText', false, 'Hello,'); | |
| 100 document.execCommand('insertText', false, 'zz.'); | |
| 101 }, | |
| 102 generateExpectedText('span', false), | |
| 103 'Change "spellcheck" of <span> from false to false'); | |
| 104 | |
| 105 spellcheck_test( | |
| 106 generateInputText('input', undefined), | |
| 107 document => { | |
| 108 const target = document.getElementById('target'); | |
| 109 target.spellcheck = true; | |
| 110 target.focus(); | |
| 111 document.execCommand('insertText', false, 'Hello,'); | |
| 112 document.execCommand('insertText', false, 'zz.'); | |
| 113 }, | |
| 114 generateExpectedText('input', true), | |
| 115 'Change "spellcheck" of <input> from undefined to true'); | |
| 116 | |
| 117 spellcheck_test( | |
| 118 generateInputText('input', undefined), | |
| 119 document => { | |
| 120 const target = document.getElementById('target'); | |
| 121 target.spellcheck = false; | |
| 122 target.focus(); | |
| 123 document.execCommand('insertText', false, 'Hello,'); | |
| 124 document.execCommand('insertText', false, 'zz.'); | |
| 125 }, | |
| 126 generateExpectedText('input', false), | |
| 127 'Change "spellcheck" of <input> from undefined to false'); | |
| 128 | |
| 129 spellcheck_test( | |
| 130 generateInputText('input', true), | |
| 131 document => { | |
| 132 const target = document.getElementById('target'); | |
| 133 target.spellcheck = true; | |
| 134 target.focus(); | |
| 135 document.execCommand('insertText', false, 'Hello,'); | |
| 136 document.execCommand('insertText', false, 'zz.'); | |
| 137 }, | |
| 138 generateExpectedText('input', true), | |
| 139 'Change "spellcheck" of <input> from true to true'); | |
| 140 | |
| 141 spellcheck_test( | |
| 142 generateInputText('input', true), | |
| 143 document => { | |
| 144 const target = document.getElementById('target'); | |
| 145 target.spellcheck = false; | |
| 146 target.focus(); | |
| 147 document.execCommand('insertText', false, 'Hello,'); | |
| 148 document.execCommand('insertText', false, 'zz.'); | |
| 149 }, | |
| 150 generateExpectedText('input', false), | |
| 151 'Change "spellcheck" of <input> from true to false'); | |
| 152 | |
| 153 spellcheck_test( | |
| 154 generateInputText('input', false), | |
| 155 document => { | |
| 156 const target = document.getElementById('target'); | |
| 157 target.spellcheck = true; | |
| 158 target.focus(); | |
| 159 document.execCommand('insertText', false, 'Hello,'); | |
| 160 document.execCommand('insertText', false, 'zz.'); | |
| 161 }, | |
| 162 generateExpectedText('input', true), | |
| 163 'Change "spellcheck" of <input> from false to true'); | |
| 164 | |
| 165 spellcheck_test( | |
| 166 generateInputText('input', false), | |
| 167 document => { | |
| 168 const target = document.getElementById('target'); | |
| 169 target.spellcheck = false; | |
| 170 target.focus(); | |
| 171 document.execCommand('insertText', false, 'Hello,'); | |
| 172 document.execCommand('insertText', false, 'zz.'); | |
| 173 }, | |
| 174 generateExpectedText('input', false), | |
| 175 'Change "spellcheck" of <input> from false to false'); | |
| 176 | |
| 177 spellcheck_test( | |
| 178 generateInputText('textarea', undefined), | |
| 179 document => { | |
| 180 const target = document.getElementById('target'); | |
| 181 target.spellcheck = true; | |
| 182 target.focus(); | |
| 183 document.execCommand('insertText', false, 'Hello,'); | |
| 184 document.execCommand('insertText', false, 'zz.'); | |
| 185 }, | |
| 186 generateExpectedText('textarea', true), | |
| 187 'Change "spellcheck" of <textarea> from undefined to true'); | |
| 188 | |
| 189 spellcheck_test( | |
| 190 generateInputText('textarea', undefined), | |
| 191 document => { | |
| 192 const target = document.getElementById('target'); | |
| 193 target.spellcheck = false; | |
| 194 target.focus(); | |
| 195 document.execCommand('insertText', false, 'Hello,'); | |
| 196 document.execCommand('insertText', false, 'zz.'); | |
| 197 }, | |
| 198 generateExpectedText('textarea', false), | |
| 199 'Change "spellcheck" of <textarea> from undefined to false'); | |
| 200 | |
| 201 spellcheck_test( | |
| 202 generateInputText('textarea', true), | |
| 203 document => { | |
| 204 const target = document.getElementById('target'); | |
| 205 target.spellcheck = true; | |
| 206 target.focus(); | |
| 207 document.execCommand('insertText', false, 'Hello,'); | |
| 208 document.execCommand('insertText', false, 'zz.'); | |
| 209 }, | |
| 210 generateExpectedText('textarea', true), | |
| 211 'Change "spellcheck" of <textarea> from true to true'); | |
| 212 | |
| 213 spellcheck_test( | |
| 214 generateInputText('textarea', true), | |
| 215 document => { | |
| 216 const target = document.getElementById('target'); | |
| 217 target.spellcheck = false; | |
| 218 target.focus(); | |
| 219 document.execCommand('insertText', false, 'Hello,'); | |
| 220 document.execCommand('insertText', false, 'zz.'); | |
| 221 }, | |
| 222 generateExpectedText('textarea', false), | |
| 223 'Change "spellcheck" of <textarea> from true to false'); | |
| 224 | |
| 225 spellcheck_test( | |
| 226 generateInputText('textarea', false), | |
| 227 document => { | |
| 228 const target = document.getElementById('target'); | |
| 229 target.spellcheck = true; | |
| 230 target.focus(); | |
| 231 document.execCommand('insertText', false, 'Hello,'); | |
| 232 document.execCommand('insertText', false, 'zz.'); | |
| 233 }, | |
| 234 generateExpectedText('textarea', true), | |
| 235 'Change "spellcheck" of <textarea> from false to true'); | |
| 236 | |
| 237 spellcheck_test( | |
| 238 generateInputText('textarea', false), | |
| 239 document => { | |
| 240 const target = document.getElementById('target'); | |
| 241 target.spellcheck = false; | |
| 242 target.focus(); | |
| 243 document.execCommand('insertText', false, 'Hello,'); | |
| 244 document.execCommand('insertText', false, 'zz.'); | |
| 245 }, | |
| 246 generateExpectedText('textarea', false), | |
| 247 'Change "spellcheck" of <textarea> from false to false'); | |
| 248 </script> | |
| OLD | NEW |