Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

Issue 2453223002: rebaseline-cl: Don't rebaseline expected-MISSING tests. (Closed)
Patch Set: - Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
index 31537ca881661e03f20fd8b893415951e9e38460..583ae885b3fe83da9a327bc4044ba3dff2f4d68a 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
@@ -190,13 +190,15 @@ class RebaselineCL(AbstractParallelRebaselineCommand):
"""Fetches a list of tests that should be rebaselined."""
buildbot = self._tool.buildbot
results_url = buildbot.results_url(build.builder_name, build.build_number)
+
layout_test_results = buildbot.fetch_layout_test_results(results_url)
if layout_test_results is None:
_log.warning('Failed to request layout test results from "%s".', results_url)
return []
- failure_results = layout_test_results.unexpected_mismatch_results()
- missing_results = layout_test_results.missing_results()
- tests = sorted(r.test_name() for r in failure_results + missing_results)
+
+ unexpected_results = layout_test_results.didnt_run_as_expected_results()
+ tests = sorted(r.test_name() for r in unexpected_results
+ if r.is_missing_baseline() or r.has_mismatch_result())
new_failures = self._fetch_tests_with_new_failures(build)
if new_failures is None:
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698