Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py

Issue 2453223002: rebaseline-cl: Don't rebaseline expected-MISSING tests. (Closed)
Patch Set: - Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py
index 64fa7e7ceeab5c697fbda91a48599bdd5e707e6b..056e613a49957df82b7fd0e623e1ad8e9af404e7 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py
@@ -117,18 +117,16 @@ class LayoutTestResultsTest(unittest.TestCase):
self.assertEqual(results.result_for_test("fast/dom/prototype-taco.html").actual_results(), "PASS TEXT")
self.assertFalse(results.result_for_test("nonexistant.html"))
- def test_unexpected_mismatch_results(self):
+ def test_didnt_run_as_expected_results(self):
results = LayoutTestResults.results_from_string(self.example_full_results_json)
self.assertEqual(
- [r.test_name() for r in results.unexpected_mismatch_results()],
+ [r.test_name() for r in results.didnt_run_as_expected_results()],
[
+ 'fast/dom/prototype-banana.html',
+ 'fast/dom/prototype-crashy.html',
'fast/dom/prototype-inheritance.html',
+ 'fast/dom/prototype-newtest.html',
+ 'fast/dom/prototype-strawberry.html',
'fast/dom/prototype-taco.html',
- 'svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html'
+ 'svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html',
])
-
- def test_missing_baseline(self):
- results = LayoutTestResults.results_from_string(self.example_full_results_json)
- missing_results = results.missing_results()
- self.assertEqual(len(missing_results), 1)
- self.assertEqual(missing_results[0].test_name(), "fast/dom/prototype-newtest.html")

Powered by Google App Engine
This is Rietveld 408576698