Use correct histogram name in security_state_model

Use correct histogram name in security_state_model

Histograms.xml uses "SSL.MarkHttpAsStatus" but the code omitted
the "SSL." prefix. This CL fixes the code to match the XML.

BUG=659667
Committed: https://crrev.com/fc254a3aee4b483f4bbc0acaa37dbe71648c06ef
Cr-Commit-Position: refs/heads/master@{#427794}

[elawrence, 2016-10-26 18:42:14]

The CQ bit was checked by elawrence@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 18:42:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[elawrence, 2016-10-26 18:43:05]

elawrence@chromium.org changed reviewers:
+ estark@chromium.org

[elawrence, 2016-10-26 18:43:05]

PTAL. Is the test reasonable?

[estark, 2016-10-26 19:53:27]

Thanks, lgtm with a couple nits.

https://codereview.chromium.org/2453063002/diff/1/components/security_state/s...
File components/security_state/security_state_model_unittest.cc (right):

https://codereview.chromium.org/2453063002/diff/1/components/security_state/s...
components/security_state/security_state_model_unittest.cc:320: 
nit: I'd suggest creating the HistogramTester at the top of the test and doing:

histograms.ExpectTotalCount("SSL.MarkHttpAsStatus", 0)

here, just to make extra clear that the sample came from the GetSecurityInfo()
call. (Not from, say, creating the SecurityStateModel.)

https://codereview.chromium.org/2453063002/diff/1/components/security_state/s...
components/security_state/security_state_model_unittest.cc:324:
2/*HTTP_SHOW_WARNING*/, 1);
nit: whitespace should be:
2 /* HTTP_SHOW_WARNING */

[estark, 2016-10-26 20:23:44]

still lgtm

[elawrence, 2016-10-26 20:24:27]

The CQ bit was checked by elawrence@chromium.org

[commit-bot: I haz the power, 2016-10-26 20:24:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:16:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 21:17:51]

Description was changed from

==========
Use correct histogram name in security_state_model

Histograms.xml uses "SSL.MarkHttpAsStatus" but the code omitted
the "SSL." prefix. This CL fixes the code to match the XML.

BUG=659667
==========

to

==========
Use correct histogram name in security_state_model

Histograms.xml uses "SSL.MarkHttpAsStatus" but the code omitted
the "SSL." prefix. This CL fixes the code to match the XML.

BUG=659667

Committed: https://crrev.com/fc254a3aee4b483f4bbc0acaa37dbe71648c06ef
Cr-Commit-Position: refs/heads/master@{#427794}
==========

[commit-bot: I haz the power, 2016-10-26 21:17:52]

Patchset 2 (id:??) landed as
https://crrev.com/fc254a3aee4b483f4bbc0acaa37dbe71648c06ef
Cr-Commit-Position: refs/heads/master@{#427794}