Use correct histogram name in security_state_model

components/security_state/security_state_model_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/security_state/security_state_model.h"
 
 #include <stdint.h>
 
 #include "base/command_line.h"
+#include "base/test/histogram_tester.h"
 #include "components/security_state/security_state_model_client.h"
 #include "components/security_state/switches.h"
 #include "net/cert/x509_certificate.h"
 #include "net/ssl/ssl_cipher_suite_names.h"
 #include "net/ssl/ssl_connection_status_flags.h"
 #include "net/test/cert_test_util.h"
 #include "net/test/test_certificate_data.h"
 #include "net/test/test_data_directory.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 275 matching lines @@
   TestSecurityStateModelClient client;
   client.UseHttpUrl();
   SecurityStateModel model;
   model.SetClient(&client);
   SecurityStateModel::SecurityInfo security_info;
   model.GetSecurityInfo(&security_info);
   EXPECT_FALSE(security_info.displayed_private_user_data_input_on_http);
   EXPECT_EQ(SecurityStateModel::NONE, security_info.security_level);
 }
 
+// Tests that SSL.MarkHttpAsStatus histogram is updated when security state is
+// computed for a page containing a password field on HTTP.
+TEST(SecurityStateModelTest, MarkHttpAsStatusHistogram) {
+  base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+      switches::kMarkHttpAs,
+      switches::kMarkHttpWithPasswordsOrCcWithChip);
+  TestSecurityStateModelClient client;
+  client.UseHttpUrl();
+  SecurityStateModel model;
+  model.SetClient(&client);
+  client.set_displayed_password_field_on_http(true);
+  SecurityStateModel::SecurityInfo security_info;
+
+  base::HistogramTester histograms;
+

[estark, 2016/10/26 19:53:27]

nit: I'd suggest creating the HistogramTester at the top of the test and doing:

histograms.ExpectTotalCount("SSL.MarkHttpAsStatus", 0)

here, just to make extra clear that the sample came from the GetSecurityInfo()
call. (Not from, say, creating the SecurityStateModel.)

+  model.GetSecurityInfo(&security_info);
+
+  histograms.ExpectUniqueSample("SSL.MarkHttpAsStatus",
+      2/*HTTP_SHOW_WARNING*/, 1);

[estark, 2016/10/26 19:53:27]

nit: whitespace should be:
2 /* HTTP_SHOW_WARNING */

+}
+
 }  // namespace
 
 }  // namespace security_state