ChromeOS: This CL moves chromeos/login/user_names* to user_mananger.

ChromeOS: This CL moves chromeos/login/user_names* to user_mananger.

We need to use ChromeOS reserved user_names in user_manager, so
I am moving it to components.user_manager.

BUG=462823, 656992
TEST=none

Committed: https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02
Cr-Commit-Position: refs/heads/master@{#428103}

[Alexander Alekseev, 2016-10-26 13:44:42]

alemate@chromium.org changed reviewers:
+ sky@chromium.org, stevenjb@chromium.org, xiyuan@chromium.org

[Alexander Alekseev, 2016-10-26 13:44:44]

Please review:

stevenjb@:
  c/b/c/*
  c/b/extensions/api/networking_private/networking_private_chromeos_apitest.cc
  c/b/ui/*

xiyuan@:
  chromeos/*
  components/user_manager/*

sky@: All the rest (only tests):
  c/b/drive/*
  c/b/extensions/*
  c/b/invalidation/*
  c/b/policy/*
  c/b/profiles/*

[Alexander Alekseev, 2016-10-26 13:44:52]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 13:45:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 14:40:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 14:40:39]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2016-10-26 16:30:39]

https://codereview.chromium.org/2452983002/diff/1/components/user_manager/DEPS
File components/user_manager/DEPS (right):

https://codereview.chromium.org/2452983002/diff/1/components/user_manager/DEP...
components/user_manager/DEPS:3: "+components/user_manager/user_names.h",
We shouldn't need this line at all, right?

https://codereview.chromium.org/2452983002/diff/1/components/user_manager/use...
File components/user_manager/user_names.h (right):

https://codereview.chromium.org/2452983002/diff/1/components/user_manager/use...
components/user_manager/user_names.h:15: namespace chromeos {
Do we really need/want this in the chromeos namespace?

[sky, 2016-10-26 17:52:40]

LGTM

[Alexander Alekseev, 2016-10-26 20:41:25]

https://codereview.chromium.org/2452983002/diff/1/components/user_manager/DEPS
File components/user_manager/DEPS (right):

https://codereview.chromium.org/2452983002/diff/1/components/user_manager/DEP...
components/user_manager/DEPS:3: "+components/user_manager/user_names.h",
On 2016/10/26 16:30:39, stevenjb wrote:
> We shouldn't need this line at all, right?

Done.

https://codereview.chromium.org/2452983002/diff/1/components/user_manager/use...
File components/user_manager/user_names.h (right):

https://codereview.chromium.org/2452983002/diff/1/components/user_manager/use...
components/user_manager/user_names.h:15: namespace chromeos {
On 2016/10/26 16:30:39, stevenjb wrote:
> Do we really need/want this in the chromeos namespace?

Done.

[Alexander Alekseev, 2016-10-26 20:41:34]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 20:42:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 20:45:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 20:45:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[xiyuan, 2016-10-26 20:51:43]

lgtm

https://codereview.chromium.org/2452983002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/app_mode/kiosk_app_manager.cc (right):

https://codereview.chromium.org/2452983002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/app_mode/kiosk_app_manager.cc:49: #include
"components/user_manager/user_names.h"
seems no longer used, can we remove it?

[Alexander Alekseev, 2016-10-26 21:50:41]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[Alexander Alekseev, 2016-10-26 21:50:48]

https://codereview.chromium.org/2452983002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/app_mode/kiosk_app_manager.cc (right):

https://codereview.chromium.org/2452983002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/app_mode/kiosk_app_manager.cc:49: #include
"components/user_manager/user_names.h"
On 2016/10/26 20:51:43, xiyuan wrote:
> seems no longer used, can we remove it?

Done.

[commit-bot: I haz the power, 2016-10-26 21:51:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stevenjb, 2016-10-26 22:31:08]

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
(right):

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:55:
#include "components/user_manager/user_names.h"
Needed?

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc
(right):

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc:22:
#include "components/user_manager/user_names.h"
needed?

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc
(right):

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc:35:
#include "components/user_manager/user_names.h"
needed?

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/signin/e...
File chrome/browser/signin/easy_unlock_service_regular.cc (right):

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/signin/e...
chrome/browser/signin/easy_unlock_service_regular.cc:66: #include
"components/user_manager/user_names.h"
needed?

[commit-bot: I haz the power, 2016-10-26 23:49:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 23:49:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2016-10-27 00:01:20]

On 2016/10/26 22:31:08, stevenjb wrote:
>
https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
> (right):
> 
>
https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:55:
> #include "components/user_manager/user_names.h"
> Needed?
> 
>
https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
> File
>
chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc
> (right):
> 
>
https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
>
chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc:22:
> #include "components/user_manager/user_names.h"
> needed?
> 
>
https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
> File
>
chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc
> (right):
> 
>
https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
>
chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc:35:
> #include "components/user_manager/user_names.h"
> needed?
> 
>
https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/signin/e...
> File chrome/browser/signin/easy_unlock_service_regular.cc (right):
> 
>
https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/signin/e...
> chrome/browser/signin/easy_unlock_service_regular.cc:66: #include
> "components/user_manager/user_names.h"
> needed?

btw, lgtm assuming that any unneeeded includes are removed.

[Alexander Alekseev, 2016-10-27 04:18:36]

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
(right):

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/existing_user_controller_browsertest.cc:55:
#include "components/user_manager/user_names.h"
On 2016/10/26 22:31:08, stevenjb wrote:
> Needed?

Done.

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc
(right):

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc:22:
#include "components/user_manager/user_names.h"
On 2016/10/26 22:31:08, stevenjb wrote:
> needed?

Done.

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
File
chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc
(right):

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc:35:
#include "components/user_manager/user_names.h"
On 2016/10/26 22:31:08, stevenjb wrote:
> needed?

Done.

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/signin/e...
File chrome/browser/signin/easy_unlock_service_regular.cc (right):

https://codereview.chromium.org/2452983002/diff/60001/chrome/browser/signin/e...
chrome/browser/signin/easy_unlock_service_regular.cc:66: #include
"components/user_manager/user_names.h"
On 2016/10/26 22:31:08, stevenjb wrote:
> needed?

Done.

[Alexander Alekseev, 2016-10-27 04:18:43]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-10-27 04:18:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
xiyuan@chromium.org, stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2452983002/#ps80001
(title: "Removed unused #includes")

[commit-bot: I haz the power, 2016-10-27 04:19:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 05:36:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 05:36:09]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Alexander Alekseev, 2016-10-27 17:17:18]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-10-27 17:17:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 19:05:35]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-27 19:32:34]

Description was changed from

==========
ChromeOS: This CL moves chromeos/login/user_names* to user_mananger.

We need to use ChromeOS reserved user_names in user_manager, so
I am moving it to components.user_manager.

BUG=462823,656992
TEST=none
==========

to

==========
ChromeOS: This CL moves chromeos/login/user_names* to user_mananger.

We need to use ChromeOS reserved user_names in user_manager, so
I am moving it to components.user_manager.

BUG=462823,656992
TEST=none

Committed: https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02
Cr-Commit-Position: refs/heads/master@{#428103}
==========

[commit-bot: I haz the power, 2016-10-27 19:32:37]

Patchset 5 (id:??) landed as
https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02
Cr-Commit-Position: refs/heads/master@{#428103}