Rename UserInfo method GetEmail to GetDisplayEmail.

Rename UserInfo method GetEmail to GetDisplayEmail.

GetEmail should be named GetDisplayEmail because it returns display email.

BUG=462823, 546876, 656992
TEST=none

Committed: https://crrev.com/bc19dbb8c8a64decb28d4abc5cefaf74d246ab1c
Cr-Commit-Position: refs/heads/master@{#429078}

[Alexander Alekseev, 2016-10-26 07:25:21]

alemate@chromium.org changed reviewers:
+ oshima@chromium.org, sky@chromium.org, xiyuan@chromium.org

[Alexander Alekseev, 2016-10-26 07:25:21]

Since this method has always had returned display email (per comment in
user_info.h), let's rename it to avoid confusion.

Please review:

oshima:
  ash/*
  c/b/ui/ash/*

sky:
  c/b/ui/views/frame/system_menu_model_builder.cc

xiyuan:
  components/user_manager/*

[Alexander Alekseev, 2016-10-26 07:25:27]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 07:25:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 07:29:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 07:29:26]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Alexander Alekseev, 2016-10-26 07:30:59]

Description was changed from

==========
Rename UserInfo method GetEmail to GetDisplayEmail.

GetEmail should be named GetDisplayEmail because it returns display email.

BUG=462823
TEST=none
==========

to

==========
Rename UserInfo method GetEmail to GetDisplayEmail.

GetEmail should be named GetDisplayEmail because it returns display email.

BUG=462823,546876
TEST=none
==========

[Alexander Alekseev, 2016-10-26 10:34:30]

Please review:

oshima:
  ash/*
  c/b/ui/ash/*

sky:
  c/b/ui/views/frame/system_menu_model_builder.cc

xiyuan:
  components/user_manager/*
  chromeos/BUILD.gn

[Alexander Alekseev, 2016-10-26 10:34:53]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 10:35:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 10:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 10:55:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexander Alekseev, 2016-10-26 13:52:06]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 13:52:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2016-10-26 13:55:29]

I moved all dependency changes to a separate Cl.
Sorry for confusion.

Please review:

oahima@:
  ash/common/*
  c/b/ui/ash/*

xiyuan@:
  components/user_manager/*

sky@:
  c/b/ui/views/frame/system_menu_model_builder.cc

[Alexander Alekseev, 2016-10-26 14:00:43]

Description was changed from

==========
Rename UserInfo method GetEmail to GetDisplayEmail.

GetEmail should be named GetDisplayEmail because it returns display email.

BUG=462823,546876
TEST=none
==========

to

==========
Rename UserInfo method GetEmail to GetDisplayEmail.

GetEmail should be named GetDisplayEmail because it returns display email.

BUG=462823,546876, 656992
TEST=none
==========

[commit-bot: I haz the power, 2016-10-26 14:13:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 14:13:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-10-26 15:14:45]

can you look into build failures?

https://codereview.chromium.org/2450183002/diff/40001/components/user_manager...
File components/user_manager/fake_user_manager.cc (right):

https://codereview.chromium.org/2450183002/diff/40001/components/user_manager...
components/user_manager/fake_user_manager.cc:57: while (it != users_.end() &&
(*it)->GetAccountId() != account_id)
optional: or use std::find_if

[xiyuan, 2016-10-26 17:26:17]

https://codereview.chromium.org/2450183002/diff/40001/components/user_manager...
File components/user_manager/empty_user_info.h (right):

https://codereview.chromium.org/2450183002/diff/40001/components/user_manager...
components/user_manager/empty_user_info.h:20: class USER_MANAGER_EXPORT
EmptyUserInfo : public UserInfo {
While looking at the user_manager code, I found no code actually uses
EmptyUserInfo. So maybe we get rid of it?

[sky, 2016-10-26 17:53:02]

LGTM

[Alexander Alekseev, 2016-10-26 21:26:28]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 21:27:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:33:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 21:33:37]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Alexander Alekseev, 2016-10-27 04:23:04]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 04:23:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 04:41:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 04:41:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexander Alekseev, 2016-10-27 06:09:53]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 06:10:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 06:13:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 06:13:58]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Alexander Alekseev, 2016-10-27 17:22:07]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 17:22:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 17:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 17:27:47]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Alexander Alekseev, 2016-10-27 18:05:57]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 18:06:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2016-10-27 18:11:37]

https://codereview.chromium.org/2450183002/diff/40001/components/user_manager...
File components/user_manager/empty_user_info.h (right):

https://codereview.chromium.org/2450183002/diff/40001/components/user_manager...
components/user_manager/empty_user_info.h:20: class USER_MANAGER_EXPORT
EmptyUserInfo : public UserInfo {
On 2016/10/26 17:26:17, xiyuan wrote:
> While looking at the user_manager code, I found no code actually uses
> EmptyUserInfo. So maybe we get rid of it?

Done.

https://codereview.chromium.org/2450183002/diff/40001/components/user_manager...
File components/user_manager/fake_user_manager.cc (right):

https://codereview.chromium.org/2450183002/diff/40001/components/user_manager...
components/user_manager/fake_user_manager.cc:57: while (it != users_.end() &&
(*it)->GetAccountId() != account_id)
On 2016/10/26 15:14:44, oshima wrote:
> optional: or use std::find_if

Done.

[commit-bot: I haz the power, 2016-10-27 18:23:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 18:23:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[xiyuan, 2016-10-27 18:25:59]

https://codereview.chromium.org/2450183002/diff/160001/components/user_manage...
File components/user_manager/user_names.cc (right):

https://codereview.chromium.org/2450183002/diff/160001/components/user_manage...
components/user_manager/user_names.cc:11: #include
"google_apis/gaia/gaia_auth_util.h"  // nogncheck
Should we fix the deps in BUILD.gn instead of this?

https://codereview.chromium.org/2450183002/diff/160001/components/user_manage...
File components/user_manager/user_names.h (right):

https://codereview.chromium.org/2450183002/diff/160001/components/user_manage...
components/user_manager/user_names.h:22: #if defined(OS_CHROMEOS)
Why do we need to make it chromeos specific? Can we leave it for all platforms
and let the linker to get rid of the unused code?

[Alexander Alekseev, 2016-10-27 23:01:10]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 23:02:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:34:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:34:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Alexander Alekseev, 2016-10-28 03:17:33]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 03:17:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 04:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 04:10:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexander Alekseev, 2016-10-28 11:10:02]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 11:10:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2016-10-28 11:10:25]

https://codereview.chromium.org/2450183002/diff/160001/components/user_manage...
File components/user_manager/user_names.cc (right):

https://codereview.chromium.org/2450183002/diff/160001/components/user_manage...
components/user_manager/user_names.cc:11: #include
"google_apis/gaia/gaia_auth_util.h"  // nogncheck
On 2016/10/27 18:25:59, xiyuan wrote:
> Should we fix the deps in BUILD.gn instead of this?

Done.

https://codereview.chromium.org/2450183002/diff/160001/components/user_manage...
File components/user_manager/user_names.h (right):

https://codereview.chromium.org/2450183002/diff/160001/components/user_manage...
components/user_manager/user_names.h:22: #if defined(OS_CHROMEOS)
On 2016/10/27 18:25:59, xiyuan wrote:
> Why do we need to make it chromeos specific? Can we leave it for all platforms
> and let the linker to get rid of the unused code?

Done.

[commit-bot: I haz the power, 2016-10-28 12:16:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 12:16:38]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-10-28 16:40:59]

lgtm

https://codereview.chromium.org/2450183002/diff/220001/components/user_manage...
File components/user_manager/user_names.cc (right):

https://codereview.chromium.org/2450183002/diff/220001/components/user_manage...
components/user_manager/user_names.cc:65: const AccountId& StubAccountId() {
nit: move this back to before "SigninAccountId()" or update header to make the
order in h and cc match.

[Alexander Alekseev, 2016-10-31 21:31:01]

https://codereview.chromium.org/2450183002/diff/220001/components/user_manage...
File components/user_manager/user_names.cc (right):

https://codereview.chromium.org/2450183002/diff/220001/components/user_manage...
components/user_manager/user_names.cc:65: const AccountId& StubAccountId() {
On 2016/10/28 16:40:59, xiyuan wrote:
> nit: move this back to before "SigninAccountId()" or update header to make the
> order in h and cc match.

Done.

[Alexander Alekseev, 2016-10-31 21:35:46]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 21:36:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 22:54:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 22:54:13]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-11-01 17:58:34]

lgtm

[Alexander Alekseev, 2016-11-01 19:41:36]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-11-01 19:41:37]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2450183002/#ps260001
(title: "Update comment")

[commit-bot: I haz the power, 2016-11-01 19:42:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 19:49:29]

Description was changed from

==========
Rename UserInfo method GetEmail to GetDisplayEmail.

GetEmail should be named GetDisplayEmail because it returns display email.

BUG=462823,546876, 656992
TEST=none
==========

to

==========
Rename UserInfo method GetEmail to GetDisplayEmail.

GetEmail should be named GetDisplayEmail because it returns display email.

BUG=462823,546876, 656992
TEST=none
==========

[commit-bot: I haz the power, 2016-11-01 19:49:30]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2016-11-01 19:57:42]

Description was changed from

==========
Rename UserInfo method GetEmail to GetDisplayEmail.

GetEmail should be named GetDisplayEmail because it returns display email.

BUG=462823,546876, 656992
TEST=none
==========

to

==========
Rename UserInfo method GetEmail to GetDisplayEmail.

GetEmail should be named GetDisplayEmail because it returns display email.

BUG=462823,546876, 656992
TEST=none

Committed: https://crrev.com/bc19dbb8c8a64decb28d4abc5cefaf74d246ab1c
Cr-Commit-Position: refs/heads/master@{#429078}
==========

[commit-bot: I haz the power, 2016-11-01 19:57:43]

Patchset 14 (id:??) landed as
https://crrev.com/bc19dbb8c8a64decb28d4abc5cefaf74d246ab1c
Cr-Commit-Position: refs/heads/master@{#429078}