Try converting chromium.fyi remote_run to tools/build

Try converting chromium.fyi remote_run to tools/build

Trying to debug why https://codereview.chromium.org/2445193002 failed. I believe
the revision property is part of the problem; it looks like it was using chromium
revisions, which don't work with the tools/build repository.

BUG=584079
Committed: https://chromium.googlesource.com/chromium/tools/build/+/fa184336e2fadfc2f6d17668fc2efa17316f0e8f

[martiniss, 2016-10-26 23:23:32]

martiniss@chromium.org changed reviewers:
+ estaab@chromium.org, iannucci@chromium.org

[martiniss, 2016-10-26 23:23:33]

PTAL

[martiniss, 2016-10-26 23:24:19]

Tester and builder are different to verify that setting revision=None (not using
the revision getter defined at
https://cs.chromium.org/chromium/build/masters/master.chromium.fyi/master.cfg...)
causes it to work.

[estaab, 2016-10-27 01:12:00]

https://codereview.chromium.org/2452943005/diff/1/masters/master.chromium.fyi...
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/2452943005/diff/1/masters/master.chromium.fyi...
masters/master.chromium.fyi/master.cfg:1479: 'factory':
m_remote_run_chromium_src(
I think switching back to m_remote_run() already does what you want (it uses
build) so you don't need to support overriding the repository.

[martiniss, 2016-10-27 19:34:47]

PTAL

https://codereview.chromium.org/2452943005/diff/1/masters/master.chromium.fyi...
File masters/master.chromium.fyi/master.cfg (right):

https://codereview.chromium.org/2452943005/diff/1/masters/master.chromium.fyi...
masters/master.chromium.fyi/master.cfg:1479: 'factory':
m_remote_run_chromium_src(
On 2016/10/27 at 01:12:00, estaab wrote:
> I think switching back to m_remote_run() already does what you want (it uses
build) so you don't need to support overriding the repository.

Done.

[iannucci, 2016-10-27 21:31:52]

https://codereview.chromium.org/2452943005/diff/40001/masters/master.chromium...
File masters/master.chromium.fyi/master.cfg (left):

https://codereview.chromium.org/2452943005/diff/40001/masters/master.chromium...
masters/master.chromium.fyi/master.cfg:398:
repository='https://chromium.googlesource.com/chromium/src.git',
not sure this change is necessary?

[martiniss, 2016-10-27 22:45:37]

https://codereview.chromium.org/2452943005/diff/40001/masters/master.chromium...
File masters/master.chromium.fyi/master.cfg (left):

https://codereview.chromium.org/2452943005/diff/40001/masters/master.chromium...
masters/master.chromium.fyi/master.cfg:398:
repository='https://chromium.googlesource.com/chromium/src.git',
On 2016/10/27 at 21:31:52, iannucci wrote:
> not sure this change is necessary?

Oops. That should not have been removed.

[iannucci, 2016-10-27 22:46:46]

lgtm

[estaab, 2016-10-27 22:47:25]

lgtm

[martiniss, 2016-10-27 23:28:22]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:28:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:38:48]

Description was changed from

==========
Try converting chromium.fyi remote_run to tools/build

Trying to debug why https://codereview.chromium.org/2445193002 failed. I believe
the revision property is part of the problem; it looks like it was using
chromium
revisions, which don't work with the tools/build repository.

BUG=584079
==========

to

==========
Try converting chromium.fyi remote_run to tools/build

Trying to debug why https://codereview.chromium.org/2445193002 failed. I believe
the revision property is part of the problem; it looks like it was using
chromium
revisions, which don't work with the tools/build repository.

BUG=584079

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/fa184336e2fadfc2f6d1...
==========

[commit-bot: I haz the power, 2016-10-27 23:38:49]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/fa184336e2fadfc2f6d1...