Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2452943005: Try converting chromium.fyi remote_run to tools/build (Closed)

Created:
4 years, 1 month ago by martiniss
Modified:
4 years, 1 month ago
Reviewers:
estaab, iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Try converting chromium.fyi remote_run to tools/build Trying to debug why https://codereview.chromium.org/2445193002 failed. I believe the revision property is part of the problem; it looks like it was using chromium revisions, which don't work with the tools/build repository. BUG=584079 Committed: https://chromium.googlesource.com/chromium/tools/build/+/fa184336e2fadfc2f6d17668fc2efa17316f0e8f

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments #

Patch Set 3 : Remove extraneous #

Total comments: 2

Patch Set 4 : Re-add repo url #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
martiniss
PTAL
4 years, 1 month ago (2016-10-26 23:23:33 UTC) #2
martiniss
Tester and builder are different to verify that setting revision=None (not using the revision getter ...
4 years, 1 month ago (2016-10-26 23:24:19 UTC) #3
estaab
https://codereview.chromium.org/2452943005/diff/1/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/2452943005/diff/1/masters/master.chromium.fyi/master.cfg#newcode1479 masters/master.chromium.fyi/master.cfg:1479: 'factory': m_remote_run_chromium_src( I think switching back to m_remote_run() already ...
4 years, 1 month ago (2016-10-27 01:12:00 UTC) #4
martiniss
PTAL https://codereview.chromium.org/2452943005/diff/1/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (right): https://codereview.chromium.org/2452943005/diff/1/masters/master.chromium.fyi/master.cfg#newcode1479 masters/master.chromium.fyi/master.cfg:1479: 'factory': m_remote_run_chromium_src( On 2016/10/27 at 01:12:00, estaab wrote: ...
4 years, 1 month ago (2016-10-27 19:34:47 UTC) #5
iannucci
https://codereview.chromium.org/2452943005/diff/40001/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (left): https://codereview.chromium.org/2452943005/diff/40001/masters/master.chromium.fyi/master.cfg#oldcode398 masters/master.chromium.fyi/master.cfg:398: repository='https://chromium.googlesource.com/chromium/src.git', not sure this change is necessary?
4 years, 1 month ago (2016-10-27 21:31:52 UTC) #6
martiniss
https://codereview.chromium.org/2452943005/diff/40001/masters/master.chromium.fyi/master.cfg File masters/master.chromium.fyi/master.cfg (left): https://codereview.chromium.org/2452943005/diff/40001/masters/master.chromium.fyi/master.cfg#oldcode398 masters/master.chromium.fyi/master.cfg:398: repository='https://chromium.googlesource.com/chromium/src.git', On 2016/10/27 at 21:31:52, iannucci wrote: > not ...
4 years, 1 month ago (2016-10-27 22:45:37 UTC) #7
iannucci
lgtm
4 years, 1 month ago (2016-10-27 22:46:46 UTC) #8
estaab
lgtm
4 years, 1 month ago (2016-10-27 22:47:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452943005/60001
4 years, 1 month ago (2016-10-27 23:28:26 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:38:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/fa184336e2fadfc2f6d1...

Powered by Google App Engine
This is Rietveld 408576698