Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 2445193002: Change all remote run builders to use tools/build. (Closed)

Created:
4 years, 1 month ago by martiniss
Modified:
4 years, 1 month ago
Reviewers:
estaab, iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org, seanmccullough
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Change all remote run builders to use tools/build. Recipe rolling is stuck too often, and is causing CLs in build to not take effect for a day, which is bad. For the time being, we're going to use remote run on the recipes in tools build, so that the roller is not in a critical path (except for build_internal, but that's a much smaller volume of CLs). BUG=584079 Committed: https://chromium.googlesource.com/chromium/tools/build/+/5dc34222177fc2ae1146de6331fc5809af19c90f

Patch Set 1 #

Patch Set 2 : Re-upload #

Patch Set 3 : Add recipes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14696 lines, -15715 lines) Patch
M masters/master.chromium.android/builders.pyl View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.chrome/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.chromiumos/builders.pyl View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.fyi/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.goma/builders.pyl View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.gpu.fyi/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.gpu/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.memory.full/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.perf.fyi/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium.perf/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.chromium/master_full_cfg.py View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.client.v8.fyi/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.blink/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.chromium.android/builders.pyl View 15 chunks +0 lines, -15 lines 0 comments Download
M masters/master.tryserver.chromium.angle/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.chromium.linux/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.chromium.mac/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.chromium.win/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M masters/master.tryserver.v8/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
A scripts/slave/recipes/android/perf.py View 1 2 1 chunk +375 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 1 2 17 chunks +375 lines, -399 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 1 2 17 chunks +375 lines, -399 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 1 2 17 chunks +375 lines, -399 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 1 2 17 chunks +350 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 1 2 17 chunks +350 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 1 2 17 chunks +350 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json View 1 2 17 chunks +375 lines, -399 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__2_.json View 1 2 17 chunks +375 lines, -399 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__3_.json View 1 2 17 chunks +375 lines, -399 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 1 2 17 chunks +352 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 1 2 17 chunks +350 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 1 2 17 chunks +350 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 1 2 17 chunks +350 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 1 2 17 chunks +350 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 1 2 17 chunks +350 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 1 2 17 chunks +350 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 1 2 17 chunks +350 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json View 1 2 17 chunks +338 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/host_info_failure.json View 1 2 17 chunks +361 lines, -401 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/missing_device.json View 1 2 18 chunks +356 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/provision_devices.json View 1 2 5 chunks +156 lines, -143 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 1 2 18 chunks +389 lines, -402 lines 0 comments Download
A + scripts/slave/recipes/android/perf.expected/test_failure.json View 1 2 18 chunks +356 lines, -402 lines 0 comments Download
A scripts/slave/recipes/blink_downstream.py View 1 2 1 chunk +277 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_fail.json View 1 2 15 chunks +148 lines, -183 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_pass.json View 1 2 11 chunks +105 lines, -91 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json View 1 2 14 chunks +209 lines, -237 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json View 1 2 11 chunks +105 lines, -95 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json View 1 2 14 chunks +205 lines, -233 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json View 1 2 11 chunks +101 lines, -91 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json View 1 2 14 chunks +260 lines, -238 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json View 1 2 13 chunks +106 lines, -113 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json View 1 2 11 chunks +219 lines, -268 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json View 1 2 12 chunks +103 lines, -94 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json View 1 2 13 chunks +205 lines, -233 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json View 1 2 25 chunks +92 lines, -245 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/webkit_tests_interrupted.json View 1 2 11 chunks +119 lines, -92 lines 0 comments Download
A + scripts/slave/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json View 1 2 11 chunks +119 lines, -92 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
martiniss
PTAL Will try to land Tuesday, October 25th at 5 PM PST. Will canary first ...
4 years, 1 month ago (2016-10-25 00:45:38 UTC) #2
martiniss
ping7
4 years, 1 month ago (2016-10-25 20:48:07 UTC) #3
iannucci
Did you already copy the recipe entry points from src to build? If so, lgtm.
4 years, 1 month ago (2016-10-25 21:02:40 UTC) #4
martiniss
Just copied the recipes back. I just diffed chromium and it's not a clean diff. ...
4 years, 1 month ago (2016-10-25 21:22:57 UTC) #5
martiniss
Actually, the diffs are because there's a very small chromium recipe in chromium src. So ...
4 years, 1 month ago (2016-10-25 21:25:53 UTC) #6
estaab
lgtm, be careful. :)
4 years, 1 month ago (2016-10-25 22:18:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445193002/2
4 years, 1 month ago (2016-10-25 23:52:59 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 00:05:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:2) as
https://chromium.googlesource.com/chromium/tools/build/+/5dc34222177fc2ae1146...

Powered by Google App Engine
This is Rietveld 408576698