Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: extensions/browser/app_window/BUILD.gn

Issue 2452943003: Fix a bunch of generated file build flakes in //extensions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/BUILD.gn
diff --git a/extensions/browser/app_window/BUILD.gn b/extensions/browser/app_window/BUILD.gn
index 41971d75fcde85c1b9af10e15c1fc00c8fbc965c..d7eda1fe6a853d9fb99ab5d537c70916373de0c2 100644
--- a/extensions/browser/app_window/BUILD.gn
+++ b/extensions/browser/app_window/BUILD.gn
@@ -29,6 +29,7 @@ source_set("app_window") {
deps = [
"//content/public/common",
+ "//extensions:extensions_resources",
Devlin 2016/10/26 19:30:28 could this just be extensions_browser_resources?
tsniatowski 2016/10/26 20:43:41 Checked -- yes. I can change this if you prefer.
Devlin 2016/10/26 21:57:52 Please. extensions_resources includes renderer re
"//extensions/strings",
]
}

Powered by Google App Engine
This is Rietveld 408576698