Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: extensions/browser/guest_view/web_view/BUILD.gn

Issue 2452943003: Fix a bunch of generated file build flakes in //extensions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/BUILD.gn
diff --git a/extensions/browser/guest_view/web_view/BUILD.gn b/extensions/browser/guest_view/web_view/BUILD.gn
index 6ae8d76185e2ef70c68dbd2d98e89f6d1091fd30..15e229bc10d28312b2da7d6beb6abe24322af595 100644
--- a/extensions/browser/guest_view/web_view/BUILD.gn
+++ b/extensions/browser/guest_view/web_view/BUILD.gn
@@ -25,7 +25,10 @@ source_set("web_view") {
]
deps = [
+ "//components/guest_view/browser",
Devlin 2016/10/26 19:30:28 Do none of the other extensions/browser/guest_view
tsniatowski 2016/10/26 20:43:41 Apparently not from an "are there missing dependen
Devlin 2016/10/26 21:57:52 Let's hoist this up to extensions/browser/guest_vi
+ "//components/web_cache/browser",
"//content/public/common",
"//extensions/common/api",
+ "//extensions/strings",
]
}

Powered by Google App Engine
This is Rietveld 408576698