Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2452943002: [turbofan] Remove dead kArchTailCallJSFunction. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove dead kArchTailCallJSFunction. The tail-call operator for invoking a JSFunction object from within stub code has been dead for a while and untested by now. This removes support for such a construct. R=bmeurer@chromium.org Committed: https://crrev.com/20c4370ddddd867734ee0e684102ad0e63a12f82 Cr-Commit-Position: refs/heads/master@{#40583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -68 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 1 month ago (2016-10-26 10:35:06 UTC) #1
Benedikt Meurer
Awesome, LGTM!
4 years, 1 month ago (2016-10-26 11:03:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452943002/1
4 years, 1 month ago (2016-10-26 11:18:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 11:21:10 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:13:37 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/20c4370ddddd867734ee0e684102ad0e63a12f82
Cr-Commit-Position: refs/heads/master@{#40583}

Powered by Google App Engine
This is Rietveld 408576698