Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Side by Side Diff: src/compiler/ia32/code-generator-ia32.cc

Issue 2452943002: [turbofan] Remove dead kArchTailCallJSFunction. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/arm64/code-generator-arm64.cc ('k') | src/compiler/instruction.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/compilation-info.h" 7 #include "src/compilation-info.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 if (FLAG_debug_code) { 573 if (FLAG_debug_code) {
574 // Check the function's context matches the context argument. 574 // Check the function's context matches the context argument.
575 __ cmp(esi, FieldOperand(func, JSFunction::kContextOffset)); 575 __ cmp(esi, FieldOperand(func, JSFunction::kContextOffset));
576 __ Assert(equal, kWrongFunctionContext); 576 __ Assert(equal, kWrongFunctionContext);
577 } 577 }
578 __ call(FieldOperand(func, JSFunction::kCodeEntryOffset)); 578 __ call(FieldOperand(func, JSFunction::kCodeEntryOffset));
579 RecordCallPosition(instr); 579 RecordCallPosition(instr);
580 frame_access_state()->ClearSPDelta(); 580 frame_access_state()->ClearSPDelta();
581 break; 581 break;
582 } 582 }
583 case kArchTailCallJSFunctionFromJSFunction: 583 case kArchTailCallJSFunctionFromJSFunction: {
584 case kArchTailCallJSFunction: {
585 Register func = i.InputRegister(0); 584 Register func = i.InputRegister(0);
586 if (FLAG_debug_code) { 585 if (FLAG_debug_code) {
587 // Check the function's context matches the context argument. 586 // Check the function's context matches the context argument.
588 __ cmp(esi, FieldOperand(func, JSFunction::kContextOffset)); 587 __ cmp(esi, FieldOperand(func, JSFunction::kContextOffset));
589 __ Assert(equal, kWrongFunctionContext); 588 __ Assert(equal, kWrongFunctionContext);
590 } 589 }
591 if (arch_opcode == kArchTailCallJSFunctionFromJSFunction) { 590 AssemblePopArgumentsAdaptorFrame(kJavaScriptCallArgCountRegister, no_reg,
592 AssemblePopArgumentsAdaptorFrame(kJavaScriptCallArgCountRegister, 591 no_reg, no_reg);
593 no_reg, no_reg, no_reg);
594 }
595 __ jmp(FieldOperand(func, JSFunction::kCodeEntryOffset)); 592 __ jmp(FieldOperand(func, JSFunction::kCodeEntryOffset));
596 frame_access_state()->ClearSPDelta(); 593 frame_access_state()->ClearSPDelta();
597 frame_access_state()->SetFrameAccessToDefault(); 594 frame_access_state()->SetFrameAccessToDefault();
598 break; 595 break;
599 } 596 }
600 case kArchPrepareCallCFunction: { 597 case kArchPrepareCallCFunction: {
601 // Frame alignment requires using FP-relative frame addressing. 598 // Frame alignment requires using FP-relative frame addressing.
602 frame_access_state()->SetFrameAccessToFP(); 599 frame_access_state()->SetFrameAccessToFP();
603 int const num_parameters = MiscField::decode(instr->opcode()); 600 int const num_parameters = MiscField::decode(instr->opcode());
604 __ PrepareCallCFunction(num_parameters, i.TempRegister(0)); 601 __ PrepareCallCFunction(num_parameters, i.TempRegister(0));
(...skipping 1653 matching lines...) Expand 10 before | Expand all | Expand 10 after
2258 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc; 2255 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc;
2259 __ Nop(padding_size); 2256 __ Nop(padding_size);
2260 } 2257 }
2261 } 2258 }
2262 2259
2263 #undef __ 2260 #undef __
2264 2261
2265 } // namespace compiler 2262 } // namespace compiler
2266 } // namespace internal 2263 } // namespace internal
2267 } // namespace v8 2264 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/arm64/code-generator-arm64.cc ('k') | src/compiler/instruction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698