Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 245293003: Revert of Run `svn cleanup` before every update and reset. (Closed)

Created:
6 years, 8 months ago by ghost stip (do not use)
Modified:
6 years, 8 months ago
Reviewers:
Dirk Pranke, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Revert of Run `svn cleanup` before every update and reset. (https://chromiumcodereview.appspot.com/240503007/) Reason for revert: It's inconclusive if this actually helped the bots, so reverting. Original issue's description: > Run `svn cleanup` before every update and reset. > > Testing on a bot with an 'unclean' Chromium checkout: > > Unpatched `gclient revert -v -v -v --nohooks --upstream` (unclean checkout) > real 9m14.280s > user 0m37.238s > sys 0m37.738s > > Patched 'gclient revert -v -v -v --nohooks --upstream' (unclean checkout) > real 5m50.065s > user 1m18.889s > sys 0m57.860s > > ---------------- after patched gclient revert run (cleans the checkout) > > Unpatched 'gclient revert -v -v -v --nohooks --upstream' (clean checkout) > real 0m21.602s > user 0m24.966s > sys 0m13.969s > > Patched 'gclient revert -v -v -v --nohooks --upstream' (clean checkout) > real 0m27.467s > user 0m28.382s > sys 0m22.629s > > BUG=336983 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=264753 TBR=dpranke@chromium.org,iannucci@chromium.org NOTREECHECKS=true NOTRY=true BUG=336983 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=265093

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -42 lines) Patch
M gclient_scm.py View 2 chunks +12 lines, -9 lines 0 comments Download
M tests/gclient_scm_test.py View 11 chunks +19 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ghost stip (do not use)
Created Revert of Run `svn cleanup` before every update and reset.
6 years, 8 months ago (2014-04-21 22:16:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/245293003/1
6 years, 8 months ago (2014-04-21 22:16:29 UTC) #2
commit-bot: I haz the power
Change committed as 265093
6 years, 8 months ago (2014-04-21 22:18:04 UTC) #3
Dirk Pranke
6 years, 8 months ago (2014-04-21 22:27:52 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698