Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: gclient_scm.py

Issue 245293003: Revert of Run `svn cleanup` before every update and reset. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/gclient_scm_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index 3baa071514272e74d1501a414d917918caa6a87a..79a0adf8f6b760bb4abf6379787b381f9df46c34 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -1196,13 +1196,18 @@
'Try using @unmanaged.\n%s') % (
self.checkout_path, from_info))
- try:
- self._Run(['cleanup', self.checkout_path], options)
- except subprocess2.CalledProcessError, e:
- # Look for locked directories.
- dir_info = scm.SVN.CaptureStatus(
- None, os.path.join(self.checkout_path, '.'))
- if any(d[0][2] == 'L' for d in dir_info):
+ # Look for locked directories.
+ dir_info = scm.SVN.CaptureStatus(
+ None, os.path.join(self.checkout_path, '.'))
+ if any(d[0][2] == 'L' for d in dir_info):
+ try:
+ self._Run(['cleanup', self.checkout_path], options)
+ except subprocess2.CalledProcessError, e:
+ # Get the status again, svn cleanup may have cleaned up at least
+ # something.
+ dir_info = scm.SVN.CaptureStatus(
+ None, os.path.join(self.checkout_path, '.'))
+
# Try to fix the failures by removing troublesome files.
for d in dir_info:
if d[0][2] == 'L':
@@ -1355,8 +1360,6 @@
# Don't reuse the args.
return self.update(options, [], file_list)
- self._Run(['cleanup', self.checkout_path], options)
-
def printcb(file_status):
if file_list is not None:
file_list.append(file_status[1])
« no previous file with comments | « no previous file | tests/gclient_scm_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698