Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2452743004: INPUT element: Fix integer overflow in input.stepDown(). (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years, 1 month ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT element: Fix integer overflow in input.stepDown(). -n doesn't work for n=-2147483648. BUG=658717 Committed: https://crrev.com/28c02d6167e1c545716f433dc84e3656da28c816 Cr-Commit-Position: refs/heads/master@{#427681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/number/number-stepup-stepdown.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/number/number-stepup-stepdown-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
Keishi, would you review this please?
4 years, 1 month ago (2016-10-26 04:26:39 UTC) #6
keishi
LGTM
4 years, 1 month ago (2016-10-26 11:27:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452743004/1
4 years, 1 month ago (2016-10-26 13:24:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 14:06:11 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 14:08:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28c02d6167e1c545716f433dc84e3656da28c816
Cr-Commit-Position: refs/heads/master@{#427681}

Powered by Google App Engine
This is Rietveld 408576698