Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: third_party/WebKit/Source/core/html/forms/InputType.h

Issue 2452743004: INPUT element: Fix integer overflow in input.stepDown(). (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/InputType.h
diff --git a/third_party/WebKit/Source/core/html/forms/InputType.h b/third_party/WebKit/Source/core/html/forms/InputType.h
index 54529a7ceeb9447c7df907ed5064e79b5320b8ba..666238e41c4ee12f7d339c941b1c137db18b8176 100644
--- a/third_party/WebKit/Source/core/html/forms/InputType.h
+++ b/third_party/WebKit/Source/core/html/forms/InputType.h
@@ -139,7 +139,7 @@ class CORE_EXPORT InputType : public GarbageCollectedFinalized<InputType> {
bool stepMismatch(const String&) const;
virtual bool getAllowedValueStep(Decimal*) const;
virtual StepRange createStepRange(AnyStepHandling) const;
- virtual void stepUp(int, ExceptionState&);
+ virtual void stepUp(double, ExceptionState&);
virtual void stepUpFromLayoutObject(int);
virtual String badInputText() const;
virtual String rangeOverflowText(const Decimal& maximum) const;
@@ -252,7 +252,7 @@ class CORE_EXPORT InputType : public GarbageCollectedFinalized<InputType> {
// Helper for stepUp()/stepDown(). Adds step value * count to the current
// value.
void applyStep(const Decimal&,
- int count,
+ double count,
AnyStepHandling,
TextFieldEventBehavior,
ExceptionState&);
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.cpp ('k') | third_party/WebKit/Source/core/html/forms/InputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698