Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2452733004: Removed unnecessary rule feature reset when no ScopedStyleResolver. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years, 1 month ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unnecessary rule feature reset when no ScopedStyleResolver. Resetting rule features when a shadow tree did not contain any stylesheets, and hence didn't have a ScopedStyleResolver, caused a performance regression in the select-single-remove performance test. UA shadow trees typically don't have any stylesheets. This is a regression from [1]. [1] https://codereview.chromium.org/2443933002 R=meade@chromium.org BUG=659535 TEST=PerformanceTests/DOM/select-single-remove.html Committed: https://crrev.com/72f115c8f71b04929130f9a71ff9f217cb8cbc4f Cr-Commit-Position: refs/heads/master@{#427949}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 1 month ago (2016-10-26 14:22:51 UTC) #3
meade_UTC10
lgtm
4 years, 1 month ago (2016-10-27 04:43:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452733004/1
4 years, 1 month ago (2016-10-27 05:50:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 05:55:39 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 05:57:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72f115c8f71b04929130f9a71ff9f217cb8cbc4f
Cr-Commit-Position: refs/heads/master@{#427949}

Powered by Google App Engine
This is Rietveld 408576698