Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 2443933002: Move TreeBoundaryCrossingScopes to StyleEngine. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years, 1 month ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move TreeBoundaryCrossingScopes to StyleEngine. This is split out of the work for async stylesheet updates [1], but is also part of the work on componentized style resolving in general. The moved resetAuthorStyle method on StyleEngine may soon be gone altogether as it does so in [1]. The plan is that TreeBoundaryCrossingScopes will also be completely gone when we remove support for Shadow DOM v0. For Shadow DOM v1 we can look up the scoped resolvers for the affecting scopes directly like we already do in StyleResolver::matchScopedRules for the pure v1 case. The documentation of the special casing of VTT and custom pseudo elements is updated to not suggest that these rules are handled as part of boundary crossing scopes as the current solution is better once v0 shadows go away. [1] https://codereview.chromium.org/1913833002 R=meade@chromium.org BUG=567021, 401359 Committed: https://crrev.com/c65b3eb1cc989a7a13813e4ef68042ae2e030c22 Cr-Commit-Position: refs/heads/master@{#427284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -50 lines) Patch
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 4 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 5 chunks +17 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentOrderedList.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 1 month ago (2016-10-24 13:40:08 UTC) #3
meade_UTC10
lgtm
4 years, 1 month ago (2016-10-25 02:30:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443933002/1
4 years, 1 month ago (2016-10-25 06:05:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 06:09:01 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 06:10:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c65b3eb1cc989a7a13813e4ef68042ae2e030c22
Cr-Commit-Position: refs/heads/master@{#427284}

Powered by Google App Engine
This is Rietveld 408576698