Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2452703003: Revert of [wrapper-tracing] Another write barrier Node EventTargetData (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
Reviewers:
haraken, Marcel Hlopko
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [wrapper-tracing] Another write barrier Node EventTargetData (patchset #1 id:1 of https://codereview.chromium.org/2447193002/ ) Reason for revert: Sorry for the confusion: EventTargetData is unfortunately not traced. We trace starting from EventTarget and skip the layers for performance reasons. Original issue's description: > [wrapper-tracing] Another write barrier Node EventTargetData > > Node reimplements EventTarget::ensureEventTargetData() and provides its own EventTargetData. > > BUG=chromium:468240 > R=haraken@chromium.org,hlopko@chromium.org > > Committed: https://crrev.com/8f895c0ebc9f58d668db2ab9bd3f9a3f796742c8 > Cr-Commit-Position: refs/heads/master@{#427449} TBR=haraken@chromium.org,hlopko@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:468240 Committed: https://crrev.com/da2fbf1044f2628db304a54dce0141a2d40b2d1f Cr-Commit-Position: refs/heads/master@{#427639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Michael Lippautz
Created Revert of [wrapper-tracing] Another write barrier Node EventTargetData
4 years, 1 month ago (2016-10-26 07:42:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452703003/1
4 years, 1 month ago (2016-10-26 07:42:33 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-10-26 07:42:34 UTC) #5
haraken
LGTM
4 years, 1 month ago (2016-10-26 07:43:49 UTC) #6
Marcel Hlopko
lgtm
4 years, 1 month ago (2016-10-26 07:46:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452703003/1
4 years, 1 month ago (2016-10-26 08:46:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 08:47:09 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 08:49:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da2fbf1044f2628db304a54dce0141a2d40b2d1f
Cr-Commit-Position: refs/heads/master@{#427639}

Powered by Google App Engine
This is Rietveld 408576698