Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2447193002: [wrapper-tracing] Another write barrier Node EventTargetData (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
Reviewers:
haraken, Marcel Hlopko
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[wrapper-tracing] Another write barrier Node EventTargetData Node reimplements EventTarget::ensureEventTargetData() and provides its own EventTargetData. BUG=chromium:468240 R=haraken@chromium.org,hlopko@chromium.org Committed: https://crrev.com/8f895c0ebc9f58d668db2ab9bd3f9a3f796742c8 Cr-Commit-Position: refs/heads/master@{#427449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael Lippautz
4 years, 1 month ago (2016-10-25 18:30:40 UTC) #2
haraken
LGTM
4 years, 1 month ago (2016-10-25 19:28:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447193002/1
4 years, 1 month ago (2016-10-25 19:51:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 20:10:06 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8f895c0ebc9f58d668db2ab9bd3f9a3f796742c8 Cr-Commit-Position: refs/heads/master@{#427449}
4 years, 1 month ago (2016-10-25 20:11:33 UTC) #13
Michael Lippautz
4 years, 1 month ago (2016-10-26 07:42:21 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2452703003/ by mlippautz@chromium.org.

The reason for reverting is: Sorry for the confusion: EventTargetData is
unfortunately not traced. We trace starting from EventTarget and skip the layers
for performance reasons..

Powered by Google App Engine
This is Rietveld 408576698