Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1521)

Issue 2452683002: [Extensions Docs] Update browser/page action documentation (Closed)

Created:
4 years, 1 month ago by Devlin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Docs] Update browser/page action documentation Update the documentation to indicate that the space is 16-dip (a change with MD chrome) and document that the extension system can handle any size in the manifest and will look for the closest one. BUG=636989 Committed: https://crrev.com/67980d379af2b88f530d51f0f7f608cd92707ec9 Cr-Commit-Position: refs/heads/master@{#427397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -23 lines) Patch
M chrome/common/extensions/docs/templates/intros/browserAction.html View 6 chunks +27 lines, -14 lines 0 comments Download
M chrome/common/extensions/docs/templates/intros/pageAction.html View 3 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Devlin
Antony, mind taking a look?
4 years, 1 month ago (2016-10-25 16:13:53 UTC) #2
asargent_no_longer_on_chrome
lgtm
4 years, 1 month ago (2016-10-25 17:27:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452683002/1
4 years, 1 month ago (2016-10-25 17:28:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 17:37:25 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 17:43:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67980d379af2b88f530d51f0f7f608cd92707ec9
Cr-Commit-Position: refs/heads/master@{#427397}

Powered by Google App Engine
This is Rietveld 408576698