Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/common/extensions/docs/templates/intros/pageAction.html

Issue 2452683002: [Extensions Docs] Update browser/page action documentation (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/docs/templates/intros/browserAction.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/templates/intros/pageAction.html
diff --git a/chrome/common/extensions/docs/templates/intros/pageAction.html b/chrome/common/extensions/docs/templates/intros/pageAction.html
index 2158044c746ea738e8a28331ed3a9189da2f0ac5..46c14d82a8eda9fa373a44b7233b621ea5cbd6ff 100644
--- a/chrome/common/extensions/docs/templates/intros/pageAction.html
+++ b/chrome/common/extensions/docs/templates/intros/pageAction.html
@@ -45,8 +45,9 @@ like this:
...
<b>"page_action": {
"default_icon": { <em>// optional</em>
- "19": "images/icon19.png", <em>// optional</em>
- "38": "images/icon38.png" <em>// optional</em>
+ "16": "images/icon16.png", <em>// optional</em>
+ "24": "images/icon24.png", <em>// optional</em>
+ "32": "images/icon32.png" <em>// optional</em>
},
"default_title": "Google Mail", <em>// optional; shown in tooltip</em>
"default_popup": "popup.html" <em>// optional</em>
@@ -55,10 +56,21 @@ like this:
}</pre>
<p>
-If you only provide one of the 19px or 38px icon size, the extension system will
-scale the icon you provide to the pixel density of the user's display, which
-can lose detail or make it look fuzzy. The old syntax for registering the
-default icon is still supported:
+You can provide any size icon to be used in Chrome, and Chrome will select the
+closest one and scale it to the appropriate size to fill the 16-dip space.
+However, if the exact size isn't provided, this scaling can cause the icon to
+lose detail or look fuzzy.
+</p>
+
+<p>
+Since devices with less-common scale factors like 1.5x or 1.2x are becoming more
+common, you are encouraged to provide multiple sizes for your icons. This also
+ensures that if the icon display size is ever changed, you don't need to do any
+more work to provide different icons!
+</p>
+
+<p>
+The old syntax for registering the default icon is still supported:
</p>
<pre data-filename="manifest.json">
@@ -67,11 +79,12 @@ default icon is still supported:
...
<b>"page_action": {
...
- "default_icon": "images/icon38.png" <em>// optional</em>
- <em>// equivalent to "default_icon": { "38": "images/icon38.png" }</em>
+ "default_icon": "images/icon32.png" <em>// optional</em>
+ <em>// equivalent to "default_icon": { "32": "images/icon32.png" }</em>
}</b>,
...
-}</pre>
+}
+</pre>
<h2 id="ui">Parts of the UI</h2>
« no previous file with comments | « chrome/common/extensions/docs/templates/intros/browserAction.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698