Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5716)

Unified Diff: chrome/browser/installable/installable_manager.h

Issue 2452603004: Update comments in InstallableManager. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_manager.h
diff --git a/chrome/browser/installable/installable_manager.h b/chrome/browser/installable/installable_manager.h
index 92ac41eb5d66afa7e45beab6257fd72bae7dc22a..8cec9c20f60df2a3d1e2a5d90d64f3de62444096 100644
--- a/chrome/browser/installable/installable_manager.h
+++ b/chrome/browser/installable/installable_manager.h
@@ -157,11 +157,13 @@ class InstallableManager
void OnDidGetManifest(const GURL& manifest_url,
const content::Manifest& manifest);
+ // Methods checking for InstallableParams-independent basic requirements.
dominickn 2016/10/27 00:26:36 This comment isn't accurate. CheckServiceWorker()
F 2016/10/27 17:49:24 Thanks for pointing out the check_installable bit!
void CheckInstallable();
bool IsManifestValidForWebApp(const content::Manifest& manifest);
void CheckServiceWorker();
void OnDidCheckHasServiceWorker(bool has_service_worker);
+ // Methods checking for requirements specified by InstallableParams.
void CheckAndFetchBestIcon();
void OnAppIconFetched(const GURL icon_url, const SkBitmap& bitmap);
« no previous file with comments | « no previous file | chrome/browser/installable/installable_manager.cc » ('j') | chrome/browser/installable/installable_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698