Update comments in InstallableManager.

chrome/browser/installable/installable_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_
 #define CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_
 
 #include <map>
 #include <memory>
 #include <utility>
@@ skipping 139 matching lines @@
   // Methods coordinating and dispatching work for the current task.
   void RunCallback(const Task& task, InstallableStatusCode error);
   void StartNextTask();
   void WorkOnTask();
 
   // Data retrieval methods.
   void FetchManifest();
   void OnDidGetManifest(const GURL& manifest_url,
                         const content::Manifest& manifest);
 
+  // Methods checking for InstallableParams-independent basic requirements.

[dominickn, 2016/10/27 00:26:36]

This comment isn't accurate. CheckServiceWorker() isn't a basic requirement,
it's only run if InstallableParams.check_installable is true.

I don't think either of the new comments in this header file are really
necessary. Are the method names not descriptive enough?

[F, 2016/10/27 17:49:24]

Thanks for pointing out the check_installable bit! I was trying to further
distinguish these two groups of functions because CheckAndFetchBestIcon()
actually uses InstallableParams inside function body like a function parameter
while CheckInstallable() does not.

   void CheckInstallable();
   bool IsManifestValidForWebApp(const content::Manifest& manifest);
   void CheckServiceWorker();
   void OnDidCheckHasServiceWorker(bool has_service_worker);
 
+  // Methods checking for requirements specified by InstallableParams.
   void CheckAndFetchBestIcon();
   void OnAppIconFetched(const GURL icon_url, const SkBitmap& bitmap);
 
   // content::WebContentsObserver overrides
   void DidFinishNavigation(content::NavigationHandle* handle) override;
   void WebContentsDestroyed() override;
 
   const GURL& manifest_url() const;
   const content::Manifest& manifest() const;
   bool is_installable() const;
 
   // The list of <params, callback> pairs that have come from a call to GetData.
   std::vector<Task> tasks_;
 
   // Installable properties cached on this object.
   std::unique_ptr<ManifestProperty> manifest_;
   std::unique_ptr<InstallableProperty> installable_;
   std::map<IconParams, IconProperty> icons_;
 
   bool is_active_;
 
   base::WeakPtrFactory<InstallableManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(InstallableManager);
 };
 
 #endif  // CHROME_BROWSER_INSTALLABLE_INSTALLABLE_MANAGER_H_