Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5875)

Unified Diff: chrome/browser/installable/installable_manager.cc

Issue 2452603004: Update comments in InstallableManager. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_manager.cc
diff --git a/chrome/browser/installable/installable_manager.cc b/chrome/browser/installable/installable_manager.cc
index f58783fea652ac86a1891b1e766f4b41b8de54e2..7b35bfb667740e3272a6595f552e1e0a0f31afdd 100644
--- a/chrome/browser/installable/installable_manager.cc
+++ b/chrome/browser/installable/installable_manager.cc
@@ -22,7 +22,12 @@ const char kPngExtension[] = ".png";
// This constant is the icon size on Android (48dp) multiplied by the scale
// factor of a Nexus 5 device (3x). For mobile and desktop platforms, a 144px
-// icon is an approximate, appropriate lower bound.
+// icon is an approximate, appropriate lower bound. It is currently documented
+// as the minimum requirement for triggering banners on several web
+// documentation pages, e.g.
+// https://developers.google.com/web/fundamentals/engage-and-retain/app-install-banners/,
dominickn 2016/10/27 00:26:36 The links here are unnecessary (and overflow the 8
F 2016/10/27 17:49:24 Done.
+// https://developers.google.com/web/updates/2015/03/increasing-engagement-with-app-install-banners-in-chrome-for-android,
+// https://googlechrome.github.io/samples/app-install-banner/
// TODO(dominickn): consolidate with minimum_icon_size_in_dp across platforms.
const int kIconMinimumSizeInPx = 144;

Powered by Google App Engine
This is Rietveld 408576698