🏠 Merge the context menu code for NTP tiles and suggestions

[NTP] Merge the context menu code for NTP tiles and suggestions

Adds a ContextMenuHandler class that takes care of creating the
menu and triages the item clicks, allowing to remove that from
the NTPManager and the Snippet ViewHolder.

Also adds the possibility to disable touch on the legacy ScrollView,
so that we can disable scrolling while the context menu is shown.

BUG=651045
Committed: https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea
Cr-Commit-Position: refs/heads/master@{#427669}

[dgn, 2016-10-25 17:51:38]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 17:52:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2016-10-25 17:52:23]

Description was changed from

==========
[NTP] Merge the context menu code for NTP tiles and suggestions

Adds a ContextMenuHandler class that takes care of creating the
menu and triages the item clicks, allowing to remove that from
the NTPManager and the Snippet ViewHolder.

Also adds the possibility to disable touch on the legacy ScrollView,
so that we can disable scrolling while the context menu is shown.

BUG=651045
==========

to

==========
[NTP] Merge the context menu code for NTP tiles and suggestions

Adds a ContextMenuHandler class that takes care of creating the
menu and triages the item clicks, allowing to remove that from
the NTPManager and the Snippet ViewHolder.

Also adds the possibility to disable touch on the legacy ScrollView,
so that we can disable scrolling while the context menu is shown.

BUG=651045
==========

[dgn, 2016-10-25 17:52:48]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org

[dgn, 2016-10-25 17:52:49]

PTAL

[Bernhard Bauer, 2016-10-26 09:09:28]

https://codereview.chromium.org/2452543005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java
(right):

https://codereview.chromium.org/2452543005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java:54:
public interface TouchDisableableView { void setTouchEnabled(boolean enabled); }
Could you merge this into the Delegate interface? And also, instead of casting
between View and TouchDisableableView, add either a delegate method that will
return the view in question, or one that will return whether the view is
attached to a window?

https://codereview.chromium.org/2452543005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java:107:
// or swiping to dismiss an item (eg. https://crbug.com/638854, 638555, 636296)
Nit: I would use full links for all of these, for easier clickability.

[dgn, 2016-10-26 10:16:17]

PTAL

https://codereview.chromium.org/2452543005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java
(right):

https://codereview.chromium.org/2452543005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java:54:
public interface TouchDisableableView { void setTouchEnabled(boolean enabled); }
On 2016/10/26 09:09:28, Bernhard Bauer wrote:
> Could you merge this into the Delegate interface? And also, instead of casting
> between View and TouchDisableableView, add either a delegate method that will
> return the view in question, or one that will return whether the view is
> attached to a window?

I kept TouchDisableableView, as it is mostly to hide the fact that we can have a
ScrollView or RecyclerView. I'm not sure how it would address the issue if it
was in Delegate itself. It would just move the issue inside of the Delegate
implementation (MostVisitemItem here), right?

I added asView() to the interface to get rid of the ugly casts though.

https://codereview.chromium.org/2452543005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java:107:
// or swiping to dismiss an item (eg. https://crbug.com/638854, 638555, 636296)
On 2016/10/26 09:09:28, Bernhard Bauer wrote:
> Nit: I would use full links for all of these, for easier clickability.

Done.

[Bernhard Bauer, 2016-10-26 10:29:50]

lgtm

[dgn, 2016-10-26 10:38:07]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2016-10-26 10:38:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 11:36:15]

Description was changed from

==========
[NTP] Merge the context menu code for NTP tiles and suggestions

Adds a ContextMenuHandler class that takes care of creating the
menu and triages the item clicks, allowing to remove that from
the NTPManager and the Snippet ViewHolder.

Also adds the possibility to disable touch on the legacy ScrollView,
so that we can disable scrolling while the context menu is shown.

BUG=651045
==========

to

==========
[NTP] Merge the context menu code for NTP tiles and suggestions

Adds a ContextMenuHandler class that takes care of creating the
menu and triages the item clicks, allowing to remove that from
the NTPManager and the Snippet ViewHolder.

Also adds the possibility to disable touch on the legacy ScrollView,
so that we can disable scrolling while the context menu is shown.

BUG=651045
==========

[commit-bot: I haz the power, 2016-10-26 11:36:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 11:38:36]

Description was changed from

==========
[NTP] Merge the context menu code for NTP tiles and suggestions

Adds a ContextMenuHandler class that takes care of creating the
menu and triages the item clicks, allowing to remove that from
the NTPManager and the Snippet ViewHolder.

Also adds the possibility to disable touch on the legacy ScrollView,
so that we can disable scrolling while the context menu is shown.

BUG=651045
==========

to

==========
[NTP] Merge the context menu code for NTP tiles and suggestions

Adds a ContextMenuHandler class that takes care of creating the
menu and triages the item clicks, allowing to remove that from
the NTPManager and the Snippet ViewHolder.

Also adds the possibility to disable touch on the legacy ScrollView,
so that we can disable scrolling while the context menu is shown.

BUG=651045

Committed: https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea
Cr-Commit-Position: refs/heads/master@{#427669}
==========

[commit-bot: I haz the power, 2016-10-26 11:38:37]

Patchset 3 (id:??) landed as
https://crrev.com/99f920d4c9724872f6176b9c71eb7b198ed3b9ea
Cr-Commit-Position: refs/heads/master@{#427669}