chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 2452543005: 🏠 Merge the context menu code for NTP tiles and suggestions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2452543005: 🏠 Merge the context menu code for NTP tiles and suggestions (Closed)

Patch Set: address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index 275444fc886474b629b1ca3fb53dbbe490a5e56c..88400a2323ffa69cc3820cf469a11d462a238ec6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -1020,7 +1020,7 @@ private void buildMostVisitedItems(final String[] titles, final String[] urls,

offlineAvailable, i, source);

View view =

mMostVisitedDesign.createMostVisitedItemView(inflater, item, isInitialLoad);

- item.initView(view);

+ item.initView(view, mUseCardsUi ? mRecyclerView : mScrollView);

}

mMostVisitedItems[i] = item;