Fix a large number of missing dependencies in the blink gn build

Fix a large number of missing dependencies in the blink gn build

Make all blink_core_sources targets public_dep on all the code
generators in core to ensure required headers are always generated first
and a successful build does not depend on lucky ordering. Manually fix
similar dep issues in core/inspector.

There are now more dependencies than strictly necessary, but they will
only trigger the generators with no effect on build commands (tested by
checking that the patch doesn't trigger a rebuild of any c++ code).

The end result is that the total number of targets that don't have proper
deps in the 'chrome' target build goes down from over 1800 to about 40,
and no missing dependencies on gen/blink files exist.

BUG=655123
R=dpranke@chromium.org

Committed: https://crrev.com/c50ed22545a79b7947f3b3fc2efe602c63db3d8d
Cr-Commit-Position: refs/heads/master@{#427856}

[tsniatowski, 2016-10-26 06:49:57]

Description was changed from

==========
Fix a large number of missing dependencies in the blink gn build

Make all blink_core_sources targets public_dep on all the code
generators in core to ensure required headers are always generated first
and a successful build does not depend on lucky ordering. Manually fix
similar dep issues in core/inspector.

There are now more dependencies than strictly necessary, but they will
only trigger the generators with no effect on build commands (tested by
checking that the patch doesn't trigger a rebuild of any c++ code).

The end result is that the total number of targets that don't have proper
deps in the 'chrome' target build goes down from over 1800 to about 40,
and no missing dependencies on gen/blink files exist.

BUG=655123
R=dpranke@chromium.org
==========

to

==========
Fix a large number of missing dependencies in the blink gn build

Make all blink_core_sources targets public_dep on all the code
generators in core to ensure required headers are always generated first
and a successful build does not depend on lucky ordering. Manually fix
similar dep issues in core/inspector.

There are now more dependencies than strictly necessary, but they will
only trigger the generators with no effect on build commands (tested by
checking that the patch doesn't trigger a rebuild of any c++ code).

The end result is that the total number of targets that don't have proper
deps in the 'chrome' target build goes down from over 1800 to about 40,
and no missing dependencies on gen/blink files exist.

BUG=655123
R=dpranke@chromium.org
==========

[tsniatowski, 2016-10-26 06:49:57]

tsniatowski@opera.com changed reviewers:
+ thakis@chromium.org

[Dirk Pranke, 2016-10-26 17:53:18]

lgtm

[tsniatowski, 2016-10-26 17:56:39]

The CQ bit was checked by tsniatowski@opera.com

[commit-bot: I haz the power, 2016-10-26 17:57:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 18:00:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 18:00:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tsniatowski, 2016-10-26 20:55:48]

The CQ bit was checked by tsniatowski@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 20:56:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsniatowski, 2016-10-26 21:24:55]

On 2016/10/26 18:00:02, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   ios-device on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
>   ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

rebased; dpranke: should I usually ask for a new lgtm after a rebase?

[Dirk Pranke, 2016-10-26 21:37:07]

On 2016/10/26 21:24:55, tsniatowski wrote:
> rebased; dpranke: should I usually ask for a new lgtm after a rebase?

No, that's only needed when you had to make some sort of significant change
(i.e., you can use your own discretion).

(so, still lgtm).

[tsniatowski, 2016-10-26 21:38:23]

The CQ bit was unchecked by tsniatowski@opera.com

[tsniatowski, 2016-10-26 21:38:35]

The CQ bit was checked by tsniatowski@opera.com

[commit-bot: I haz the power, 2016-10-26 21:39:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 22:41:48]

Description was changed from

==========
Fix a large number of missing dependencies in the blink gn build

Make all blink_core_sources targets public_dep on all the code
generators in core to ensure required headers are always generated first
and a successful build does not depend on lucky ordering. Manually fix
similar dep issues in core/inspector.

There are now more dependencies than strictly necessary, but they will
only trigger the generators with no effect on build commands (tested by
checking that the patch doesn't trigger a rebuild of any c++ code).

The end result is that the total number of targets that don't have proper
deps in the 'chrome' target build goes down from over 1800 to about 40,
and no missing dependencies on gen/blink files exist.

BUG=655123
R=dpranke@chromium.org
==========

to

==========
Fix a large number of missing dependencies in the blink gn build

Make all blink_core_sources targets public_dep on all the code
generators in core to ensure required headers are always generated first
and a successful build does not depend on lucky ordering. Manually fix
similar dep issues in core/inspector.

There are now more dependencies than strictly necessary, but they will
only trigger the generators with no effect on build commands (tested by
checking that the patch doesn't trigger a rebuild of any c++ code).

The end result is that the total number of targets that don't have proper
deps in the 'chrome' target build goes down from over 1800 to about 40,
and no missing dependencies on gen/blink files exist.

BUG=655123
R=dpranke@chromium.org
==========

[commit-bot: I haz the power, 2016-10-26 22:41:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 22:45:15]

Description was changed from

==========
Fix a large number of missing dependencies in the blink gn build

Make all blink_core_sources targets public_dep on all the code
generators in core to ensure required headers are always generated first
and a successful build does not depend on lucky ordering. Manually fix
similar dep issues in core/inspector.

There are now more dependencies than strictly necessary, but they will
only trigger the generators with no effect on build commands (tested by
checking that the patch doesn't trigger a rebuild of any c++ code).

The end result is that the total number of targets that don't have proper
deps in the 'chrome' target build goes down from over 1800 to about 40,
and no missing dependencies on gen/blink files exist.

BUG=655123
R=dpranke@chromium.org
==========

to

==========
Fix a large number of missing dependencies in the blink gn build

Make all blink_core_sources targets public_dep on all the code
generators in core to ensure required headers are always generated first
and a successful build does not depend on lucky ordering. Manually fix
similar dep issues in core/inspector.

There are now more dependencies than strictly necessary, but they will
only trigger the generators with no effect on build commands (tested by
checking that the patch doesn't trigger a rebuild of any c++ code).

The end result is that the total number of targets that don't have proper
deps in the 'chrome' target build goes down from over 1800 to about 40,
and no missing dependencies on gen/blink files exist.

BUG=655123
R=dpranke@chromium.org

Committed: https://crrev.com/c50ed22545a79b7947f3b3fc2efe602c63db3d8d
Cr-Commit-Position: refs/heads/master@{#427856}
==========

[commit-bot: I haz the power, 2016-10-26 22:45:17]

Patchset 2 (id:??) landed as
https://crrev.com/c50ed22545a79b7947f3b3fc2efe602c63db3d8d
Cr-Commit-Position: refs/heads/master@{#427856}