Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2452473004: Fix a large number of missing dependencies in the blink gn build (Closed)
Patch Set: rebase (make_core_generated_input_mode_names was added meanwhile) Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/core.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 4a559485674919a7041a34bd2c1c0f01a3fc9f66..1daff2087a9864a10d1f3bf9d12163d862086fa8 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -846,59 +846,65 @@ action_foreach("make_core_generated_bison") {
deps = make_core_generated_deps
}
+# Targets from above that generate outputs that need to be compiled.
+# All sources declared as outputs from these targets will be compiled into one
+# target.
+targets_generating_sources = [
+ ":make_core_generated_bison",
+ ":make_core_generated_css_primitive_value_unit_trie",
+ ":make_core_generated_css_property_metadata",
+ ":make_core_generated_computed_style_base",
+ ":make_core_generated_css_property_names",
+ ":make_core_generated_cssom_types",
+ ":make_core_generated_event_factory",
+ ":make_core_generated_event_names",
+ ":make_core_generated_event_target_names",
+ ":make_core_generated_event_type_names",
+ ":make_core_generated_fetch_initiator_type_names",
+ ":make_core_generated_html_element_factory",
+ ":make_core_generated_html_element_lookup_trie",
+ ":make_core_generated_html_entity_table",
+ ":make_core_generated_html_tokenizer_names",
+ ":make_core_generated_input_mode_names",
+ ":make_core_generated_input_type_names",
+ ":make_core_generated_math_ml_names",
+ ":make_core_generated_media_feature_names",
+ ":make_core_generated_media_type_names",
+ ":make_core_generated_origin_trials",
+ ":make_core_generated_style_builder",
+ ":make_core_generated_style_property_shorthand",
+ ":make_core_generated_svg_names",
+ ":make_core_generated_xlink_names",
+ ":make_core_generated_xml_names",
+ ":make_core_generated_xml_ns_names",
+ ":make_core_generated_private_script",
+ ":make_core_generated_html_element_type_helpers",
+ ":make_core_generated_css_value_keywords",
+ ":make_core_generated_media_features",
+ ":make_core_generated_svg_element_type_helpers",
+ ":make_core_generated_private_script_for_testing",
+]
+
+group("all_generators") {
+ public_deps = targets_generating_sources
+ public_deps += [
+ # This target's generated source is #included into another source file.
+ # So we don't want to list it in the "generating sources" list above,
+ # but it does need to be listed as a dependency here.
+ ":make_core_generated_css_tokenizer_codepoints",
+ ]
+}
+
# Compiles the code generated by the targets above.
target(core_link_small_target_type, "core_generated") {
sources = bindings_core_v8_files
- # Targets from above that generate outputs that need to be compiled.
- # All sources declared as outputs from these targets will be compiled into this
- # target.
- targets_generating_sources = [
- ":make_core_generated_bison",
- ":make_core_generated_css_primitive_value_unit_trie",
- ":make_core_generated_css_property_metadata",
- ":make_core_generated_computed_style_base",
- ":make_core_generated_css_property_names",
- ":make_core_generated_cssom_types",
- ":make_core_generated_event_factory",
- ":make_core_generated_event_names",
- ":make_core_generated_event_target_names",
- ":make_core_generated_event_type_names",
- ":make_core_generated_fetch_initiator_type_names",
- ":make_core_generated_html_element_factory",
- ":make_core_generated_html_element_lookup_trie",
- ":make_core_generated_html_entity_table",
- ":make_core_generated_html_tokenizer_names",
- ":make_core_generated_input_mode_names",
- ":make_core_generated_input_type_names",
- ":make_core_generated_math_ml_names",
- ":make_core_generated_media_feature_names",
- ":make_core_generated_media_type_names",
- ":make_core_generated_origin_trials",
- ":make_core_generated_style_builder",
- ":make_core_generated_style_property_shorthand",
- ":make_core_generated_svg_names",
- ":make_core_generated_xlink_names",
- ":make_core_generated_xml_names",
- ":make_core_generated_xml_ns_names",
- ":make_core_generated_private_script",
- ":make_core_generated_html_element_type_helpers",
- ":make_core_generated_css_value_keywords",
- ":make_core_generated_media_features",
- ":make_core_generated_svg_element_type_helpers",
- ":make_core_generated_private_script_for_testing",
- ]
-
# Add all sources generated by the targets above.
foreach(current, targets_generating_sources) {
sources += get_target_outputs(current)
}
- public_deps = targets_generating_sources
- public_deps += [
- # This target's generated source is #included into another source file.
- # So we don't want to list it in the "generating sources" list above,
- # but it does need to be listed as a dependency here.
- ":make_core_generated_css_tokenizer_codepoints",
+ public_deps = [
+ ":all_generators",
"//third_party/WebKit/Source/bindings/core/v8:bindings_core_impl",
]
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/core.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698