Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2452473003: Do not use outdated m_distributedNodes of slots in non-shadow trees (Closed)

Created:
4 years, 1 month ago by hayato
Modified:
4 years, 1 month ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use outdated m_distributedNodes of slots in non-shadow trees HTMLSlotElement::m_distributedNodes might be outdated for slots in non-shadow trees. There are other places where outdated m_distributedNodes might be used, which could be addressed in another CL. BUG=642303 Committed: https://crrev.com/980a85e4e0dd7504cd00cb9dacf7d2b06347a24f Cr-Commit-Position: refs/heads/master@{#427650}

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/shadow-dom/crashes/slots-in-document-tree-crash.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
hayato
update
4 years, 1 month ago (2016-10-26 01:39:29 UTC) #5
hayato
PTAL
4 years, 1 month ago (2016-10-26 01:53:18 UTC) #10
kochi
lgtm
4 years, 1 month ago (2016-10-26 05:10:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452473003/20001
4 years, 1 month ago (2016-10-26 05:54:21 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 09:41:29 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 09:44:58 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/980a85e4e0dd7504cd00cb9dacf7d2b06347a24f
Cr-Commit-Position: refs/heads/master@{#427650}

Powered by Google App Engine
This is Rietveld 408576698