third_party/WebKit/Source/core/dom/Node.cpp - Issue 2452473003: Do not use outdated m_distributedNodes of slots in non-shadow trees

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2452473003: Do not use outdated m_distributedNodes of slots in non-shadow trees (Closed)

Patch Set: update Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Node.cpp

diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp

index 8059397fe39faf8fa56d3bc2bd6e957b4626d4e9..3306e156523469d72f1f851aba7f60912bc95fb7 100644

--- a/third_party/WebKit/Source/core/dom/Node.cpp

+++ b/third_party/WebKit/Source/core/dom/Node.cpp

@@ -2374,6 +2374,7 @@ void Node::checkSlotChange() {

Element* parent = parentElement();

if (parent && isHTMLSlotElement(parent)) {

HTMLSlotElement& parentSlot = toHTMLSlotElement(*parent);

+ // TODO(hayato): Support slotchange for slots in non-shadow trees.

if (ShadowRoot* root = containingShadowRoot()) {

if (root && root->isV1() && !parentSlot.hasAssignedNodesSlow())

parentSlot.enqueueSlotChangeEvent();