Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2452303003: Revert of cc : Move screen space scale factor to root transform node (Closed)

Created:
4 years, 1 month ago by jaydasika
Modified:
4 years, 1 month ago
Reviewers:
ajuma, weiliangc, chrishtr, pdr.
CC:
cc-bugs_chromium.org, chromium-reviews, sunxd
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc : Move screen space scale factor to root transform node (patchset #12 id:240001 of https://codereview.chromium.org/2408243002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=660047 Original issue's description: > cc : Move screen space scale factor to root transform node > > This CL computes the screen space scale factor which is > combined form scale factors of device transform, device > scale factor and page scale factor(if required), and stores > it on the root transform node as its surface contents scale. > This also implicitly fixes a clipping bug. > TransformTree::ComputeTransforms(a, b) should return the > transform between a and b without the surface contents > scale. But, since screen space scale was baked into the > local transform of the contents root node (before this CL), > ComputeTransform(a, root) was having the scale baked in. > (and this caused the bug) > > BUG=651584 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/61fa0fb418a3f77665e0bc1be88ec5a2984c6dc6 > Cr-Commit-Position: refs/heads/master@{#427366} TBR=weiliangc@chromium.org,ajuma@chromium.org,chrishtr@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=651584 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/18ea272710d605c67458b1edd162821d758fb645 Cr-Commit-Position: refs/heads/master@{#428221}

Patch Set 1 #

Patch Set 2 : resolve merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -150 lines) Patch
M cc/trees/draw_property_utils.cc View 1 4 chunks +18 lines, -13 lines 0 comments Download
M cc/trees/effect_node.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 1 chunk +4 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 3 chunks +2 lines, -37 lines 0 comments Download
M cc/trees/property_tree.h View 1 2 chunks +3 lines, -9 lines 0 comments Download
M cc/trees/property_tree.cc View 1 3 chunks +19 lines, -52 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 3 chunks +9 lines, -14 lines 0 comments Download
M cc/trees/property_tree_unittest.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
jaydasika
Created Revert of cc : Move screen space scale factor to root transform node
4 years, 1 month ago (2016-10-27 20:55:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452303003/1
4 years, 1 month ago (2016-10-27 20:56:43 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/95304)
4 years, 1 month ago (2016-10-27 21:01:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452303003/230001
4 years, 1 month ago (2016-10-27 21:41:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/57329)
4 years, 1 month ago (2016-10-27 22:55:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452303003/230001
4 years, 1 month ago (2016-10-27 22:57:12 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:230001)
4 years, 1 month ago (2016-10-27 23:47:43 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:49:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/18ea272710d605c67458b1edd162821d758fb645
Cr-Commit-Position: refs/heads/master@{#428221}

Powered by Google App Engine
This is Rietveld 408576698