Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2452243002: [Payments] Remove credit scan scanner experimental flag (Closed)

Created:
4 years, 1 month ago by gogerald1
Modified:
4 years, 1 month ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove credit scan scanner experimental flag BUG=640430 Committed: https://crrev.com/ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9 Cr-Commit-Position: refs/heads/master@{#428761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
gogerald1
Hi, PTAL,
4 years, 1 month ago (2016-10-27 14:57:46 UTC) #9
please use gerrit instead
lgtm
4 years, 1 month ago (2016-10-27 14:58:46 UTC) #10
gogerald1
Hi, PTAL,
4 years, 1 month ago (2016-10-28 02:36:19 UTC) #13
gone
Has the parent CL relanded? I thought I saw it get reverted.
4 years, 1 month ago (2016-10-31 17:29:02 UTC) #14
gogerald
NO, the reverted one is for different UI (showing credit card type when typing in ...
4 years, 1 month ago (2016-10-31 17:39:09 UTC) #16
gone
OK lgtm.
4 years, 1 month ago (2016-10-31 17:40:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452243002/1
4 years, 1 month ago (2016-10-31 17:42:36 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 18:48:31 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 19:18:50 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab2f596da90bc5b1d1120e02bd75144f4f9e8ef9
Cr-Commit-Position: refs/heads/master@{#428761}

Powered by Google App Engine
This is Rietveld 408576698